Move creation of PeerConnection from the RenderView to the RenderThreadImpl.

content/renderer/media/media_stream_dependency_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_dependency_factory.h"
 
 #include <vector>
 
+#include "base/metrics/histogram.h"
+#include "content/renderer/media/peer_connection_handler_jsep.h"
 #include "content/renderer/media/video_capture_impl_manager.h"
 #include "content/renderer/media/video_capture_module_impl.h"
 #include "content/renderer/media/webrtc_audio_device_impl.h"
 #include "content/renderer/p2p/ipc_network_manager.h"
 #include "content/renderer/p2p/ipc_socket_factory.h"
 #include "content/renderer/p2p/port_allocator.h"
 #include "jingle/glue/thread_wrapper.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 
+namespace {

[darin (slow to review), 2012/09/06 18:24:59]

nit: add new line below here.

[perkj_chrome, 2012/09/12 11:53:15]

Moved to webrtc_uma_histograms.

+// Helper enum used for histogramming calls to WebRTC APIs from JavaScript.
+// TODO(perkj): This is a duplicate of the code in media_stream_impl.
+// The enum and UpdateWebRTCMethodCount must bee kept in sync with

[darin (slow to review), 2012/09/06 18:24:59]

bee -> be

[perkj_chrome, 2012/09/12 13:54:38]

Done.

+// media_stream_impl. Find a better way of doing this.

[piman, 2012/09/06 17:04:45]

Can we just move it to a common header?

[perkj_chrome, 2012/09/12 11:53:15]

Done.

+enum JavaScriptAPIName {
+  kWebkitGetUserMedia,

[darin (slow to review), 2012/09/06 18:24:59]

nit: chromium follows the old google c++ style rule that has enum values in
UPPER_CASE style.

http://dev.chromium.org/developers/coding-style#Naming

[perkj_chrome, 2012/09/12 13:54:38]

Done.

+  kWebkitPeerConnection,
+  kInvalidName
+};
+
+// Helper method used to collect information about the number of times
+// different WebRTC API:s are called from JavaScript.
+// The histogram can be viewed at chrome://histograms/WebRTC.webkitApiCount.
+static void UpdateWebRTCMethodCount(JavaScriptAPIName api_name) {

[darin (slow to review), 2012/09/06 18:24:59]

nit: "static" keyword inside anonymous namespace is redundant.

[perkj_chrome, 2012/09/12 11:53:15]

Done.

+  UMA_HISTOGRAM_ENUMERATION("WebRTC.webkitApiCount", api_name, kInvalidName);
+}
+
+}  // namespace
+
 class P2PPortAllocatorFactory : public webrtc::PortAllocatorFactoryInterface {
  public:
   P2PPortAllocatorFactory(
       content::P2PSocketDispatcher* socket_dispatcher,
       talk_base::NetworkManager* network_manager,
       talk_base::PacketSocketFactory* socket_factory)
       : socket_dispatcher_(socket_dispatcher),
         network_manager_(network_manager),
         socket_factory_(socket_factory) {
   }
@@ skipping 38 matching lines @@
   talk_base::PacketSocketFactory* socket_factory_;
 };
 
 MediaStreamDependencyFactory::MediaStreamDependencyFactory(
     VideoCaptureImplManager* vc_manager)
     : vc_manager_(vc_manager) {
 }
 
 MediaStreamDependencyFactory::~MediaStreamDependencyFactory() {}
 
+WebKit::WebPeerConnection00Handler*
+MediaStreamDependencyFactory::CreatePeerConnectionHandlerJsep(
+    WebKit::WebPeerConnection00HandlerClient* client) {
+
+  // Save histogram data so we can see how much PeerConnetion is used.
+  // The histogram counts the number of calls to the JS API
+  // webKitPeerConnection00.
+  UpdateWebRTCMethodCount(kWebkitPeerConnection);
+
+  PeerConnectionHandlerJsep* pc_handler = new PeerConnectionHandlerJsep(
+      client,
+      this);
+  return pc_handler;

[piman, 2012/09/06 17:04:45]

style nit: if you just return new PeerConnectionHandlerJsep(client, this); I
think it fits in one line.

[perkj_chrome, 2012/09/12 13:54:38]

Done.

+}
+
 bool MediaStreamDependencyFactory::CreatePeerConnectionFactory(
     talk_base::Thread* worker_thread,
     talk_base::Thread* signaling_thread,
     content::P2PSocketDispatcher* socket_dispatcher,
     talk_base::NetworkManager* network_manager,
     talk_base::PacketSocketFactory* socket_factory) {
   if (!pc_factory_.get()) {
     talk_base::scoped_refptr<P2PPortAllocatorFactory> pa_factory =
         new talk_base::RefCountedObject<P2PPortAllocatorFactory>(
             socket_dispatcher,
@@ skipping 57 matching lines @@
 MediaStreamDependencyFactory::CreateSessionDescription(const std::string& sdp) {
   return webrtc::CreateSessionDescription(sdp);
 }
 
 webrtc::IceCandidateInterface* MediaStreamDependencyFactory::CreateIceCandidate(
     const std::string& sdp_mid,
     int sdp_mline_index,
     const std::string& sdp) {
   return webrtc::CreateIceCandidate(sdp_mid, sdp_mline_index, sdp);
 }