Move android mediaplayer from render process to browser process.

content/browser/android/cookie_getter_impl.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_ANDROID_COOKIE_GETTER_IMPL_H_
+#define CONTENT_BROWSER_ANDROID_COOKIE_GETTER_IMPL_H_
+
+#include <string>
+
+#include "media/base/android/cookie_getter.h"
+
+namespace net {
+class URLRequestContextGetter;
+}
+
+namespace content {
+
+// This class implements media::CookieGetter to retrive cookies
+// asynchronously on the UI thread.
+class CookieGetterImpl : public media::CookieGetter {

[scherkus (not reviewing), 2012/09/10 12:19:08]

This class should have a WeakPtrFactory object that it uses when posting the
completion callback to the IO thread

One possibility includes binding the original callback to GetCookiesCallback()
w/ a weak pointer then posting that as the callback to execute to
RequestCookies() on the IO thread. Inside ReturnCookies() you would simply post
the callback to the UI thread.

Should CookieGetterImpl get deleted the task will no-op itself on the UI thread
instead of executing and requiring clients worry about use-after-free due to
CookieGetterImpl being alive due to references maintained on the IO thread.

[qinmin, 2012/09/11 04:50:24]

Done. The callback passed from MediaPlayerBridge to this includes a weakptr, so
we are safe here. But you are right that we should not require the clients to
worry about use-after-free case. Change the code to pass weakptr between
threads.


On 2012/09/10 12:19:08, scherkus wrote:

+ public:
+  explicit CookieGetterImpl(net::URLRequestContextGetter* context_getter);
+  virtual ~CookieGetterImpl();
+
+  // media::CookieGetter implementation.
+  // Need to be called on the UI thread.

[scherkus (not reviewing), 2012/09/10 12:19:08]

s/Need to/Must/

[qinmin, 2012/09/11 04:50:24]

Done.

+  virtual void GetCookies(
+      const std::string& url, const GetCookieCB& callback) OVERRIDE;
+
+ private:
+  // Helper Methods for posting tasks.

[scherkus (not reviewing), 2012/09/10 12:19:08]

nit: remove comment (not adding much value)

[qinmin, 2012/09/11 04:50:24]

Done.

+  void GetCookiesCallback(
+    const std::string& cookies, const GetCookieCB& callback);
+  void RequestCookies(const std::string& url, const GetCookieCB& callback);
+  void ReturnCookies(const GetCookieCB& callback, const std::string& cookies);
+
+  net::URLRequestContextGetter* context_getter_;
+
+  DISALLOW_COPY_AND_ASSIGN(CookieGetterImpl);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_ANDROID_COOKIE_GETTER_IMPL_H_