Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 # Autofill is being made into a Browser Component, so we have these | 2 # Autofill is being made into a Browser Component, so we have these |
| 3 # three basic rules followed by temporary exceptions. Please don't | 3 # three basic rules followed by temporary exceptions. Please don't |
| 4 # add to the list of exceptions! | 4 # add to the list of exceptions! |
| 5 "-chrome/browser", | 5 "-chrome/browser", |
| 6 "+chrome/browser/api", | 6 "+chrome/browser/api", |
| 7 "+chrome/browser/autofill", | 7 "+chrome/browser/autofill", |
| 8 | 8 |
| 9 # Permanently-allowed DEPS beyond the standard Browser | 9 # Permanently-allowed DEPS beyond the standard Browser |
| 10 # Components-like DEPS above go here. | 10 # Components-like DEPS above go here. |
| 11 "+third_party/libphonenumber", # For phone number i18n. | 11 "+third_party/libphonenumber", # For phone number i18n. |
| 12 | 12 |
| 13 # TODO(joi): Bring this list to zero. | 13 # TODO(joi): Bring this list to zero. |
| 14 # | 14 # |
| 15 # Do not add to the list of temporarily-allowed dependencies below, | 15 # Do not add to the list of temporarily-allowed dependencies below, |
| 16 # and please do not introduce more #includes of these files. | 16 # and please do not introduce more #includes of these files. |
| 17 | |
| 18 # Can go once ProfileSyncService is converted. | |
| 17 "!chrome/browser/profiles/profile.h", | 19 "!chrome/browser/profiles/profile.h", |
| 20 | |
| 21 # Moving to api | |
| 22 "!chrome/browser/profiles/profile_keyed_service.h", | |
| 23 | |
| 24 # Will go when PersonalDataManagerFactory moves to c/b/configuration. | |
| 18 "!chrome/browser/profiles/profile_dependency_manager.h", | 25 "!chrome/browser/profiles/profile_dependency_manager.h", |
| 19 "!chrome/browser/profiles/profile_keyed_service.h", | |
| 20 "!chrome/browser/profiles/profile_keyed_service_factory.h", | 26 "!chrome/browser/profiles/profile_keyed_service_factory.h", |
| 27 | |
| 28 # Needs abstract base. | |
|
erikwright (departed)
2012/09/04 19:42:14
As a side comment, I am always confused when I see
Jói
2012/09/04 20:10:25
We could just say "API" since that's what we're ca
| |
| 21 "!chrome/browser/sync/profile_sync_service.h", | 29 "!chrome/browser/sync/profile_sync_service.h", |
| 22 "!chrome/browser/sync/profile_sync_service_factory.h", | 30 "!chrome/browser/sync/profile_sync_service_factory.h", |
| 23 "!chrome/browser/sync/profile_sync_service_observer.h", | 31 "!chrome/browser/sync/profile_sync_service_observer.h", |
| 32 | |
| 24 "!chrome/browser/ui/tab_contents/tab_contents.h", | 33 "!chrome/browser/ui/tab_contents/tab_contents.h", |
| 34 | |
| 25 # Do not add to the list of temporarily-allowed dependencies above, | 35 # Do not add to the list of temporarily-allowed dependencies above, |
| 26 # and please do not introduce more #includes of these files. | 36 # and please do not introduce more #includes of these files. |
| 27 | 37 |
| 28 # TODO(akalin): Remove this dependency. | 38 # TODO(akalin): Remove this dependency. |
| 29 "!sync/util/data_encryption_win.h", | 39 "!sync/util/data_encryption_win.h", |
| 30 ] | 40 ] |
| 31 | 41 |
| 32 specific_include_rules = { | 42 specific_include_rules = { |
| 33 # TODO(joi): Bring this list to zero. | 43 # TODO(joi): Bring this list to zero. |
| 34 # | 44 # |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 47 "!chrome/browser/ui/tab_contents/tab_autofill_manager_delegate.h", | 57 "!chrome/browser/ui/tab_contents/tab_autofill_manager_delegate.h", |
| 48 "!chrome/browser/ui/tab_contents/test_tab_contents.h", | 58 "!chrome/browser/ui/tab_contents/test_tab_contents.h", |
| 49 ], | 59 ], |
| 50 | 60 |
| 51 # TODO(joi): Get rid of the need for this, e.g. by moving | 61 # TODO(joi): Get rid of the need for this, e.g. by moving |
| 52 # PersonalDataManagerFactory to chrome/browser/configuration. | 62 # PersonalDataManagerFactory to chrome/browser/configuration. |
| 53 'personal_data_manager_factory\.cc': [ | 63 'personal_data_manager_factory\.cc': [ |
| 54 "!chrome/browser/webdata/web_data_service_factory.h", | 64 "!chrome/browser/webdata/web_data_service_factory.h", |
| 55 ], | 65 ], |
| 56 } | 66 } |
| OLD | NEW |