Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/ui/panels/detached_panel_strip.cc

Issue 10919046: Allow panels to be created as detached panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/detached_panel_strip.cc
diff --git a/chrome/browser/ui/panels/detached_panel_strip.cc b/chrome/browser/ui/panels/detached_panel_strip.cc
index b3c6394fbc9a69bee9c85beae1b4ba8e1b7d357e..3b54817485f5b6d0d5abbb21946f3ddf527d52d7 100644
--- a/chrome/browser/ui/panels/detached_panel_strip.cc
+++ b/chrome/browser/ui/panels/detached_panel_strip.cc
@@ -9,6 +9,12 @@
#include "chrome/browser/ui/panels/panel_drag_controller.h"
#include "chrome/browser/ui/panels/panel_manager.h"
+namespace {
+// How much horizontal and vertical offset there is between newly opened
+// detached panels.
+const int kPanelTilePixels = 10;
+} // namespace
+
DetachedPanelStrip::DetachedPanelStrip(PanelManager* panel_manager)
: PanelStrip(PanelStrip::DETACHED),
panel_manager_(panel_manager) {
@@ -66,6 +72,11 @@ void DetachedPanelStrip::AddPanel(Panel* panel,
DCHECK_NE(this, panel->panel_strip());
panel->set_panel_strip(this);
panels_.insert(panel);
+
+ // Offset the default position of the next detached panel if the current
+ // default position is used.
+ if (panel->GetBounds().origin() == default_panel_origin_)
+ default_panel_origin_.Offset(kPanelTilePixels, kPanelTilePixels);
jianli 2012/09/04 21:58:47 What if next default panel origin is out of screen
jennb 2012/09/04 23:02:44 Will modify to "wrap-around". Detached panel bound
}
void DetachedPanelStrip::RemovePanel(Panel* panel) {
@@ -228,3 +239,12 @@ void DetachedPanelStrip::UpdatePanelOnStripChange(Panel* panel) {
void DetachedPanelStrip::OnPanelActiveStateChanged(Panel* panel) {
}
+const gfx::Point& DetachedPanelStrip::GetDefaultPanelOrigin() {
+ if (!default_panel_origin_.x() && !default_panel_origin_.y()) {
+ gfx::Rect display_area =
+ panel_manager_->display_settings_provider()->GetDisplayArea();
+ default_panel_origin_.SetPoint(kPanelTilePixels + display_area.x(),
+ kPanelTilePixels + display_area.y());
+ }
+ return default_panel_origin_;
+}

Powered by Google App Engine
This is Rietveld 408576698