Allow panels to be created as detached panels.

chrome/test/data/extensions/api_test/window_open/panel_detached/test.js

Index: chrome/test/data/extensions/api_test/window_open/panel_detached/test.js
diff --git a/chrome/test/data/extensions/api_test/window_open/panel_detached/test.js b/chrome/test/data/extensions/api_test/window_open/panel_detached/test.js
new file mode 100644
index 0000000000000000000000000000000000000000..e79245be265f9f9ebf93da3692d665c69bb8ada0
--- /dev/null
+++ b/chrome/test/data/extensions/api_test/window_open/panel_detached/test.js
@@ -0,0 +1,72 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function createCallback(win) {
+    chrome.test.assertEq('panel', win.type);

[Mihai Parparita -not on Chrome, 2012/09/05 20:37:00]

Nit: indented one too many times.

[jennb, 2012/09/05 21:11:07]

Done.

+    // Unlike docked panels, detached is not alwaysOnTop.
+    chrome.test.assertEq(false, win.alwaysOnTop);
+}
+
+chrome.test.runTests([
+  // No origin nor size is specified.
+  function openDetachedPanel() {
+    chrome.test.listenOnce(chrome.windows.onCreated, function(window) {
+      chrome.test.assertEq("panel", window.type);
+      chrome.test.assertTrue(!window.incognito);
+      chrome.test.assertTrue(window.width > 0);
+      chrome.test.assertTrue(window.height > 0);
+    });
+    chrome.windows.create(
+        { 'url': chrome.extension.getURL('about:blank'),

[Mihai Parparita -not on Chrome, 2012/09/05 20:37:00]

chrome.extension.getURL('about:blank') doesn't quite make sense. getURL is meant
for getting URLs of resources in the extension packages, but about:blank isn't a
resource. You should be able to use about:blank directly.

[jennb, 2012/09/05 21:11:07]

Good catch, thanks! Copy/paste/edit fail fixed.

+          'type': 'detached_panel' },
+        chrome.test.callbackPass(createCallback));
+  },
+
+  // Verify supplied size is obeyed even if no origin is specified.
+  function openDetachedPanelWithSize() {
+    chrome.test.listenOnce(chrome.windows.onCreated, function(window) {
+      chrome.test.assertEq("panel", window.type);
+      chrome.test.assertTrue(!window.incognito);
+      chrome.test.assertEq(250, window.width);
+      chrome.test.assertEq(300, window.height);
+    });
+    chrome.windows.create(
+        { 'url': chrome.extension.getURL('about:blank'),
+          'type': 'detached_panel', 'width': 250, 'height': 300 },
+        chrome.test.callbackPass(createCallback));
+  },
+
+  // Verify supplied origin is obeyed even if no size is specified.
+  function openDetachedPanelWithOrigin() {
+    chrome.test.listenOnce(chrome.windows.onCreated, function(window) {
+      chrome.test.assertEq("panel", window.type);
+      chrome.test.assertTrue(!window.incognito);
+      chrome.test.assertEq(42, window.top);
+      chrome.test.assertEq(24, window.left);
+      chrome.test.assertTrue(window.width > 0);
+      chrome.test.assertTrue(window.height > 0);
+    });
+    chrome.windows.create(
+        { 'url': chrome.extension.getURL('about:blank'),
+          'type': 'detached_panel', 'top': 42, 'left': 24 },
+        chrome.test.callbackPass(createCallback));
+  },
+
+  // Verify supplied bounds are obeyed.
+  function openDetachedPanelWithFullBounds() {
+    chrome.test.listenOnce(chrome.windows.onCreated, function(window) {
+      chrome.test.assertEq("panel", window.type);
+      chrome.test.assertTrue(!window.incognito);
+      chrome.test.assertEq(42, window.top);
+      chrome.test.assertEq(24, window.left);
+      chrome.test.assertEq(250, window.width);
+      chrome.test.assertEq(300, window.height);
+    });
+    chrome.windows.create(
+        { 'url': chrome.extension.getURL('about:blank'),
+          'type': 'detached_panel', 'top': 42, 'left': 24,
+          'width': 250, 'height': 300 },
+        chrome.test.callbackPass(createCallback));
+  }
+]);