Allow panels to be created as detached panels.

chrome/browser/ui/panels/panel_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_
 
 #include <vector>
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
@@ skipping 10 matching lines @@
 class DockedPanelStrip;
 class GURL;
 class PanelDragController;
 class PanelResizeController;
 class PanelMouseWatcher;
 
 // This class manages a set of panels.
 class PanelManager : public DisplaySettingsProvider::DisplayAreaObserver,
                      public DisplaySettingsProvider::FullScreenObserver {
  public:
+  enum CreateMode {
+    CREATE_DOCKED,  // Creates a docked panel. The default.

[jianli, 2012/09/04 21:58:47]

Maybe CREATE_AS_DOCKED?

[jennb, 2012/09/04 23:02:44]

Done.

+    CREATE_DETACHED  // Creates a detached panel.
+  };
+
   // Returns a single instance.
   static PanelManager* GetInstance();
 
   // Returns true if panels should be used for the extension.
   static bool ShouldUsePanels(const std::string& extension_id);
 
   // Returns true if using browserless panels. False if using old panels.
   // TODO(jennb): Delete after refactor.
   static bool UseBrowserlessPanels();
 
+  // Returns the default top-left position for a detached panel.
+  const gfx::Point& GetDefaultDetachedPanelOrigin();
+
   // Creates a panel and returns it. The panel might be queued for display
   // later.
   // |app_name| is the default title for Panels when the page content does not
   // provide a title. For extensions, this is usually the application name
   // generated from the extension id.
-  // |requested_size| is the desired size for the panel, but actual
-  // size may differ after panel layout.
+  // |requested_bounds| is the desired bounds for the panel, but actual
+  // bounds may differ after panel layout depending on create |mode|.
+  // |mode| indicates whether panel should be created as docked or detached.
   Panel* CreatePanel(const std::string& app_name,
                      Profile* profile,
                      const GURL& url,
-                     const gfx::Size& requested_size);
+                     const gfx::Rect& requested_bounds,
+                     CreateMode mode);
   Panel* CreatePanel(Browser* browser);  // legacy
 
   // Close all panels (asynchronous). Panels will be removed after closing.
   void CloseAll();
 
   // Asynchronous confirmation of panel having been closed.
   void OnPanelClosed(Panel* panel);
 
   // Returns the maximum size that panel can be auto-resized or resized by the
   // API.
@@ skipping 104 matching lines @@
   friend struct base::DefaultLazyInstanceTraits<PanelManager>;
 
   PanelManager();
   virtual ~PanelManager();
 
   // Combined CreatePanel() logic until we can delete legacy CreatePanel().
   Panel* CreatePanel(Browser* browser,
                      const std::string& app_name,
                      Profile* profile,
                      const GURL& url,
-                     const gfx::Size& requested_size);
+                     const gfx::Rect& requested_bounds,
+                     CreateMode mode);
 
   // Overridden from DisplaySettingsProvider::DisplayAreaObserver:
   virtual void OnDisplayAreaChanged(const gfx::Rect& display_area) OVERRIDE;
 
   // Overridden from DisplaySettingsProvider::FullScreenObserver:
   virtual void OnFullScreenModeChanged(bool is_full_screen) OVERRIDE;
 
   // Tests may want to use a mock panel mouse watcher.
   void SetMouseWatcher(PanelMouseWatcher* watcher);
 
@@ skipping 17 matching lines @@
 
   // Whether or not bounds will be updated when the preferred content size is
   // changed. The testing code could set this flag to false so that other tests
   // will not be affected.
   bool auto_sizing_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(PanelManager);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_MANAGER_H_