Provide mutable members of UrlRequestContext via pure-virtual interface

net/url_request/url_request_context_storage.h

Index: net/url_request/url_request_context_storage.h
diff --git a/net/url_request/url_request_context_storage.h b/net/url_request/url_request_context_storage.h
index bc040b2907d91c928dab15906db654d996dc3f48..01e9730315d38de609721a2e58d39fcba16f61ee 100644
--- a/net/url_request/url_request_context_storage.h
+++ b/net/url_request/url_request_context_storage.h
@@ -20,6 +20,7 @@ class HostResolver;
 class HttpAuthHandlerFactory;
 class HttpServerProperties;
 class HttpTransactionFactory;
+class HttpUserAgentSettings;
 class NetLog;
 class NetworkDelegate;
 class ServerBoundCertService;
@@ -65,6 +66,8 @@ class NET_EXPORT URLRequestContextStorage {
       FtpTransactionFactory* ftp_transaction_factory);
   void set_job_factory(URLRequestJobFactory* job_factory);
   void set_throttler_manager(URLRequestThrottlerManager* throttler_manager);
+  void set_http_user_agent_settings(
+      HttpUserAgentSettings* http_user_agent_settings);
 
  private:
   // We use a raw pointer to prevent reference cycles, since
@@ -91,6 +94,7 @@ class NET_EXPORT URLRequestContextStorage {
   scoped_ptr<FtpTransactionFactory> ftp_transaction_factory_;
   scoped_ptr<URLRequestJobFactory> job_factory_;
   scoped_ptr<URLRequestThrottlerManager> throttler_manager_;
+  scoped_ptr<HttpUserAgentSettings> http_user_agent_settings_;

[willchan no longer on Chromium, 2012/10/24 03:40:10]

Move this earlier. The destruction order may matter here. This should definitely
be destroyed before URLRequestJobFactory, and probably before
HttpTransactionFactory.

[pauljensen, 2012/10/24 19:19:00]

By moving it earlier it will be destroyed *after* more items, not before.  I'm
guessing this is what you wanted? (so HttpUserAgentSettings dies after any
callers, avoiding use after free)

 
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextStorage);
 };