sync/internal_api/public/http_bridge.h - Issue 10918279: Provide mutable members of UrlRequestContext via pure-virtual interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/http_bridge.h

Issue 10918279: Provide mutable members of UrlRequestContext via pure-virtual interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address erikwright's second round of comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_context_builder.cc ('K') | « sync/internal_api/http_bridge.cc ('k') | webkit/tools/test_shell/test_shell_request_context.h » ('j') | webkit/tools/test_shell/test_shell_request_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/http_bridge.h

diff --git a/sync/internal_api/public/http_bridge.h b/sync/internal_api/public/http_bridge.h

index 15001c2182c737be774b1b36364b9607795dff9d..359484467a17cc264dcf926041fda61b0b3f7370 100644

--- a/sync/internal_api/public/http_bridge.h

+++ b/sync/internal_api/public/http_bridge.h

@@ -24,6 +24,7 @@ class MessageLoop;

class HttpBridgeTest;

namespace net {

+class ConstHttpUserAgentSettings;

class HttpResponseHeaders;

class URLFetcher;

}

@@ -58,12 +59,11 @@ class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,

// The destructor MUST be called on the IO thread.

virtual ~RequestContext();

- virtual const std::string& GetUserAgent(const GURL& url) const OVERRIDE;

private:

net::URLRequestContext* const baseline_context_;

const scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;

- const std::string user_agent_;

+ scoped_ptr<net::ConstHttpUserAgentSettings>

+ const_http_user_agent_settings_;

DISALLOW_COPY_AND_ASSIGN(RequestContext);

};