Provide mutable members of UrlRequestContext via pure-virtual interface

chrome/browser/profiles/profile_impl_io_data.cc

Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index 4e7e378b5b3ed8250d15fee8dc37546f221a8f62..37fcbb15eb47ed77530de70b78815ff355910026 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/api/prefs/pref_member.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/net/about_protocol_handler.h"
+#include "chrome/browser/net/basic_http_user_agent_settings.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/clear_on_exit_policy.h"
 #include "chrome/browser/net/connect_interceptor.h"
@@ -317,6 +318,12 @@ void ProfileImplIOData::LazyInitializeInternal(
 
   // Initialize context members.
 
+  http_user_agent_settings_.reset(new BasicHttpUserAgentSettings(

[erikwright (departed), 2012/09/21 15:06:33]

I'm not certain, but I think that the main_context (and probably the
extensions_request_context are ChromeURLRequestContext instances and therefore
already are configured with the ChromeUserAgentSettings.

The same might also apply to the OffTheRecord profile.

If that's the case, replacing it would break the preferences-tracking
functionality.

+      profile_params->accept_language, profile_params->accept_charset));
+  main_context->set_http_user_agent_settings(http_user_agent_settings_.get());
+  extensions_context->set_http_user_agent_settings(
+      http_user_agent_settings_.get());
+
   ApplyProfileParamsToContext(main_context);
   ApplyProfileParamsToContext(extensions_context);