Provide mutable members of UrlRequestContext via pure-virtual interface

chrome/browser/net/basic_http_user_agent_settings.h

Index: chrome/browser/net/basic_http_user_agent_settings.h
diff --git a/chrome/browser/net/basic_http_user_agent_settings.h b/chrome/browser/net/basic_http_user_agent_settings.h
new file mode 100644
index 0000000000000000000000000000000000000000..6752f28a15016cf6a1b882424c0c5c75360ab1c8
--- /dev/null
+++ b/chrome/browser/net/basic_http_user_agent_settings.h
@@ -0,0 +1,30 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_BASIC_HTTP_USER_AGENT_SETTINGS_H_
+#define CHROME_BROWSER_NET_BASIC_HTTP_USER_AGENT_SETTINGS_H_
+
+#include <string>
+
+#include "net/url_request/url_request_context.h"
+
+// An implementation of |HttpUserAgentSettings| (goes into |URLRequestContext|)

[erikwright (departed), 2012/09/21 15:06:33]

no need for the parenthetical.

+// that provides fixed values for the HTTP headers Accept-Language and
+// Accept-Charset; and, uses |content::GetUserAgent| to provide the HTTP

[erikwright (departed), 2012/09/21 15:06:33]

remove ';' and ','

+// User-Agent header value.
+class BasicHttpUserAgentSettings
+  : public net::ConstHttpAcceptLanguageAndCharset {
+ public:
+  BasicHttpUserAgentSettings(const std::string& accept_language,
+                             const std::string& accept_charset);
+  virtual ~BasicHttpUserAgentSettings() {}
+
+  virtual const std::string& GetUserAgent(const GURL& url) OVERRIDE;

[erikwright (departed), 2012/09/21 15:06:33]

Prefix with comment:
// ConstHttpAcceptLanguageAndCharset implementation

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BasicHttpUserAgentSettings);
+};
+
+#endif  // CHROME_BROWSER_NET_BASIC_HTTP_USER_AGENT_SETTINGS_H_
+