content/browser/speech/google_streaming_remote_engine.cc - Issue 10918279: Provide mutable members of UrlRequestContext via pure-virtual interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_streaming_remote_engine.cc

Issue 10918279: Provide mutable members of UrlRequestContext via pure-virtual interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address mmenke's comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_http_user_agent_settings.cc ('K') | « content/browser/speech/google_one_shot_remote_engine.cc ('k') | content/shell/shell_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/google_streaming_remote_engine.cc

diff --git a/content/browser/speech/google_streaming_remote_engine.cc b/content/browser/speech/google_streaming_remote_engine.cc

index 66bd9e664692f109887f8914dbab496d2f39724f..a50cca68478f96cf3bf85c9affc6b448ef163d5b 100644

--- a/content/browser/speech/google_streaming_remote_engine.cc

+++ b/content/browser/speech/google_streaming_remote_engine.cc

@@ -567,7 +567,10 @@ std::string GoogleStreamingRemoteEngine::GetAcceptedLanguages() const {

net::URLRequestContext* request_context =

url_context_->GetURLRequestContext();

DCHECK(request_context);

- std::string accepted_language_list = request_context->accept_language();

+ // TODO(pauljensen): GoogleStreamingRemoteEngine should be constructed with

+ // a reference to the HttpUserAgentSettings rather than accessing the

+ // accept language through the URLRequestContext.

+ std::string accepted_language_list = request_context->GetAcceptLanguage();

size_t separator = accepted_language_list.find_first_of(",;");

if (separator != std::string::npos)

langs = accepted_language_list.substr(0, separator);