Provide mutable members of UrlRequestContext via pure-virtual interface

sync/internal_api/public/http_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_HTTP_BRIDGE_H_
 #define SYNC_INTERNAL_API_PUBLIC_HTTP_BRIDGE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "googleurl/src/gurl.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "sync/internal_api/public/http_post_provider_factory.h"
 #include "sync/internal_api/public/http_post_provider_interface.h"
 
 class MessageLoop;
 class HttpBridgeTest;
 
 namespace net {
+class StaticHttpUserAgentSettings;
 class HttpResponseHeaders;
 class URLFetcher;
 }
 
 namespace syncer {
 
 // A bridge between the syncer and Chromium HTTP layers.
 // Provides a way for the sync backend to use Chromium directly for HTTP
 // requests rather than depending on a third party provider (e.g libcurl).
 // This is a one-time use bridge. Create one for each request you want to make.
@@ skipping 14 matching lines @@
     // currently active profile.
     RequestContext(
         net::URLRequestContext* baseline_context,
         const scoped_refptr<base::SingleThreadTaskRunner>&
             network_task_runner,
         const std::string& user_agent);
 
     // The destructor MUST be called on the IO thread.
     virtual ~RequestContext();
 
-    virtual const std::string& GetUserAgent(const GURL& url) const OVERRIDE;
-
    private:
     net::URLRequestContext* const baseline_context_;
     const scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
-    const std::string user_agent_;
+    scoped_ptr<net::StaticHttpUserAgentSettings>

[erikwright (departed), 2012/10/24 13:14:33]

This could be just HttpUserAgentSettings, right?

+        static_http_user_agent_settings_;
 
     DISALLOW_COPY_AND_ASSIGN(RequestContext);
   };
 
   // Lazy-getter for RequestContext objects.
   class RequestContextGetter : public net::URLRequestContextGetter {
    public:
     RequestContextGetter(
         net::URLRequestContextGetter* baseline_context_getter,
         const std::string& user_agent);
@@ skipping 145 matching lines @@
 
   const scoped_refptr<HttpBridge::RequestContextGetter>
       request_context_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpBridgeFactory);
 };
 
 }  //  namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_HTTP_BRIDGE_H_