Provide mutable members of UrlRequestContext via pure-virtual interface

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 566 matching lines @@
 
   LazyInitializeInternal(profile_params_.get());
 
   profile_params_.reset();
   initialized_ = true;
 }
 
 void ProfileIOData::ApplyProfileParamsToContext(
     ChromeURLRequestContext* context) const {
   context->set_is_incognito(is_incognito());
-  context->set_accept_language(profile_params_->accept_language);
-  context->set_accept_charset(profile_params_->accept_charset);
+  context->OnAcceptLanguageChange(profile_params_->accept_language);

[erikwright (departed), 2012/09/25 21:06:38]

Is there actually any compelling reason for these to appear in profile_params_
now?

[pauljensen, 2012/09/26 14:08:19]

They come from the prefs so I believe they must be read on the UI thread but
they need to be put into the contexts which live on the IO thread and I believe
profile_params_ is used for moving this sort of initialization parameters from
the UI to IO thread.

+  context->OnDefaultCharsetChange(profile_params_->accept_charset);
   context->set_referrer_charset(profile_params_->referrer_charset);
   context->set_ssl_config_service(profile_params_->ssl_config_service);
 }
 
 void ProfileIOData::SetUpJobFactoryDefaults(
     net::URLRequestJobFactory* job_factory) const {
   // NOTE(willchan): Keep these protocol handlers in sync with
   // ProfileIOData::IsHandledProtocol().
 
   if (profile_params_->protocol_handler_url_interceptor.get()) {
@@ skipping 87 matching lines @@
   params->http_pipelining_enabled = globals->http_pipelining_enabled;
   params->testing_fixed_http_port = globals->testing_fixed_http_port;
   params->testing_fixed_https_port = globals->testing_fixed_https_port;
 
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kTrustedSpdyProxy)) {
     params->trusted_spdy_proxy = command_line.GetSwitchValueASCII(
         switches::kTrustedSpdyProxy);
   }
 }