Provide mutable members of UrlRequestContext via pure-virtual interface

net/url_request/url_request_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_test_util.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/threading/thread.h"
@@ skipping 90 matching lines @@
   // In-memory cookie store.
   if (!cookie_store())
     context_storage_.set_cookie_store(new net::CookieMonster(NULL, NULL));
   // In-memory origin bound cert service.
   if (!server_bound_cert_service()) {
     context_storage_.set_server_bound_cert_service(
         new net::ServerBoundCertService(
             new net::DefaultServerBoundCertStore(NULL),
             base::WorkerPool::GetTaskRunner(true)));
   }
-  if (accept_language().empty())
-    set_accept_language("en-us,fr");
-  if (accept_charset().empty())
-    set_accept_charset("iso-8859-1,*,utf-8");
+  if (accept_language().empty()) {

[erikwright (departed), 2012/09/21 15:06:33]

It might be more correct to provide a method:

TestURLRequestContext::SetUserAgentValues(accept_charset, accept_language,
user_agent) {
  // set a constant user-agent settings, using the defaults "en-us, fr" etc.
}

Clients that call ::Init() obviously already know about the derived class, so
they can access that helper method to set these strings.

[pauljensen, 2012/09/24 20:21:15]

Why would this be more correct?

+    context_storage_.set_http_user_agent_settings(
+        new net::ConstHttpUserAgentSettings(
+            "en-us,fr", accept_charset(), EmptyString()));
+  }
+  if (accept_charset().empty()) {
+    context_storage_.set_http_user_agent_settings(
+        new net::ConstHttpUserAgentSettings(
+            accept_language(), "iso-8859-1,*,utf-8", EmptyString()));
+  }
   if (!job_factory())
     context_storage_.set_job_factory(new net::URLRequestJobFactoryImpl);
 }
 
 TestURLRequest::TestURLRequest(const GURL& url,
                                Delegate* delegate,
                                TestURLRequestContext* context)
     : net::URLRequest(url, delegate, context) {
 }
 
@@ skipping 424 matching lines @@
 
 net::URLRequestJob* TestJobInterceptor::MaybeInterceptResponse(
       net::URLRequest* request,
       net::NetworkDelegate* network_delegate) const {
   return NULL;
 }
 
 void TestJobInterceptor::set_main_intercept_job(net::URLRequestJob* job) {
   main_intercept_job_ = job;
 }