Provide mutable members of UrlRequestContext via pure-virtual interface

net/url_request/url_request_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_context.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/debug/stack_trace.h"
 #include "base/string_util.h"
 #include "net/base/host_resolver.h"
 #include "net/cookies/cookie_store.h"
 #include "net/ftp/ftp_transaction_factory.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/url_request/url_request.h"
 
 namespace net {
 
+ConstHttpAcceptLanguageAndCharset::ConstHttpAcceptLanguageAndCharset(

[erikwright (departed), 2012/09/21 15:06:33]

move.

+  const std::string& accept_language, const std::string& accept_charset) :
+    accept_language_(accept_language),
+    accept_charset_(accept_charset) {}

[erikwright (departed), 2012/09/21 15:06:33]

Feel free to check prior-art and tell me what is predominant in cases where the
initializer list is already wrapped (I'm not sure), but I'm pretty it's to put
the } on a newline.

+
+const std::string& ConstHttpAcceptLanguageAndCharset::GetAcceptLanguage() {
+  return accept_language_;
+}
+
+const std::string& ConstHttpAcceptLanguageAndCharset::GetAcceptCharset() {
+  return accept_charset_;
+}
+
+ConstHttpUserAgentSettings::ConstHttpUserAgentSettings(
+  const std::string& accept_language, const std::string& accept_charset,
+  const std::string& user_agent) :
+    ConstHttpAcceptLanguageAndCharset(accept_language, accept_charset),
+    user_agent_(user_agent) {}
+
+const std::string& ConstHttpUserAgentSettings::GetUserAgent(const GURL& url) {
+  return user_agent_;
+}
+
 URLRequestContext::URLRequestContext()
     : net_log_(NULL),
       host_resolver_(NULL),
       cert_verifier_(NULL),
       server_bound_cert_service_(NULL),
       fraudulent_certificate_reporter_(NULL),
       http_auth_handler_factory_(NULL),
       proxy_service_(NULL),
       network_delegate_(NULL),
       http_server_properties_(NULL),
       transport_security_state_(NULL),
 #if !defined(DISABLE_FTP_SUPPORT)
       ftp_auth_cache_(new FtpAuthCache),
 #endif
       http_transaction_factory_(NULL),
       ftp_transaction_factory_(NULL),
       job_factory_(NULL),
       throttler_manager_(NULL),
+      http_user_agent_settings_(NULL),
       url_requests_(new std::set<const URLRequest*>) {
 }
 
 URLRequestContext::~URLRequestContext() {
   AssertNoURLRequests();
 }
 
 void URLRequestContext::CopyFrom(const URLRequestContext* other) {
   // Copy URLRequestContext parameters.
   set_net_log(other->net_log_);
   set_host_resolver(other->host_resolver_);
   set_cert_verifier(other->cert_verifier_);
   set_server_bound_cert_service(other->server_bound_cert_service_);
   set_fraudulent_certificate_reporter(other->fraudulent_certificate_reporter_);
   set_http_auth_handler_factory(other->http_auth_handler_factory_);
   set_proxy_service(other->proxy_service_);
   set_ssl_config_service(other->ssl_config_service_);
   set_network_delegate(other->network_delegate_);
   set_http_server_properties(other->http_server_properties_);
   set_cookie_store(other->cookie_store_);
   set_transport_security_state(other->transport_security_state_);
   // FTPAuthCache is unique per context.
-  set_accept_language(other->accept_language_);
-  set_accept_charset(other->accept_charset_);
+  set_http_user_agent_settings(other->http_user_agent_settings_);
   set_referrer_charset(other->referrer_charset_);
   set_http_transaction_factory(other->http_transaction_factory_);
   set_ftp_transaction_factory(other->ftp_transaction_factory_);
   set_job_factory(other->job_factory_);
   set_throttler_manager(other->throttler_manager_);
 }
 
 const HttpNetworkSession::Params* URLRequestContext::GetNetworkSessionParams(
     ) const {
   HttpTransactionFactory* transaction_factory = http_transaction_factory();
   if (!transaction_factory)
     return NULL;
   HttpNetworkSession* network_session = transaction_factory->GetSession();
   if (!network_session)
     return NULL;
   return &network_session->params();
 }
 
 URLRequest* URLRequestContext::CreateRequest(
     const GURL& url, URLRequest::Delegate* delegate) const {
   return new URLRequest(url, delegate, this, network_delegate_);
 }
 
 void URLRequestContext::set_cookie_store(CookieStore* cookie_store) {
   cookie_store_ = cookie_store;
 }
 
+// Gets the value of 'Accept-Charset' header field.

[erikwright (departed), 2012/09/21 15:06:33]

no implementation comment necessary.

+const std::string& URLRequestContext::accept_charset() const {
+  if (!http_user_agent_settings_)

[erikwright (departed), 2012/09/21 15:06:33]

nit:
  return http_user_agent_settings_ ?
      http_user_agent_settings_->GetAcceptCharset() : EmptyString();

+    return EmptyString();
+  return http_user_agent_settings_->GetAcceptCharset();
+}
+
+// Gets the value of 'Accept-Language' header field.
+const std::string& URLRequestContext::accept_language() const {
+  if (!http_user_agent_settings_)
+    return EmptyString();
+  return http_user_agent_settings_->GetAcceptLanguage();
+}
+
 const std::string& URLRequestContext::GetUserAgent(const GURL& url) const {
-  return EmptyString();
+  if (!http_user_agent_settings_)
+    return EmptyString();
+  return http_user_agent_settings_->GetUserAgent(url);
 }
 
 void URLRequestContext::AssertNoURLRequests() const {
   int num_requests = url_requests_->size();
   if (num_requests != 0) {
     // We're leaking URLRequests :( Dump the URL of the first one and record how
     // many we leaked so we have an idea of how bad it is.
     char url_buf[128];
     const URLRequest* request = *url_requests_->begin();
     base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf));
     bool has_delegate = request->has_delegate();
     int load_flags = request->load_flags();
     base::debug::StackTrace stack_trace(NULL, 0);
     if (request->stack_trace())
       stack_trace = *request->stack_trace();
     base::debug::Alias(url_buf);
     base::debug::Alias(&num_requests);
     base::debug::Alias(&has_delegate);
     base::debug::Alias(&load_flags);
     base::debug::Alias(&stack_trace);
     CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "
                  << request->url().spec().c_str() << ".";
   }
 }
 
 }  // namespace net