Issue 10918276: Remove checksum in CDM interface and implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918276: Remove checksum in CDM interface and implementations. (Closed)

Created:
8 years, 3 months ago by xhwang

Modified:
8 years, 3 months ago

Reviewers:
fgalligan1, ddorwin

CC:
chromium-reviews, yusukes+watch_chromium.org, yzshen+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove checksum in CDM interface and implementations. We are removing checksum/HMAC in WebM spec for encrypted content. This CL updates the CDM interface, ClearKeyCdm, CdmWrapper and PPAPI code to reflect this change. Note the demo will break before AesDecryptor, DecryptConfig and demo files are updated as well. BUG=150014 TEST=none

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -26 lines)			Patch
M	ppapi/api/private/pp_content_decryptor.idl	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	ppapi/c/private/pp_content_decryptor.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	webkit/media/crypto/ppapi/cdm_wrapper.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/media/crypto/ppapi/clear_key_cdm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/media/crypto/ppapi/content_decryption_module.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xhwang

This CL can be commited alone (it will only break the demo, since Shadi's browser ...

8 years, 3 months ago (2012-09-17 17:14:08 UTC) #1

xhwang

8 years, 3 months ago (2012-09-18 05:38:08 UTC) #2

This CL has been merged into fgalligan's CL and will be committed there:
https://codereview.chromium.org/10917308/

Expand Messages | Collapse Messages