Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4957)

Unified Diff: chrome/browser/ui/gtk/global_error_bubble.cc

Issue 10918275: [gtk] website settings bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: slightly simpler drawing Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/first_run_bubble.cc ('k') | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/global_error_bubble.cc
diff --git a/chrome/browser/ui/gtk/global_error_bubble.cc b/chrome/browser/ui/gtk/global_error_bubble.cc
index fd22f12b403dbdacd97e7835ad407cb417abd4e5..ea6c6c1fc7d330308501a4517fece0d3f375460a 100644
--- a/chrome/browser/ui/gtk/global_error_bubble.cc
+++ b/chrome/browser/ui/gtk/global_error_bubble.cc
@@ -23,15 +23,6 @@
namespace {
-// Padding between content and edge of bubble.
-const int kContentBorder = 7;
-
-// Horizontal spacing between the image view and the label.
-const int kImageViewSpacing = 5;
-
-// Vertical spacing between labels.
-const int kInterLineSpacing = 5;
-
// Text size of the message label. 12.1px = 9pt @ 96dpi.
const double kMessageTextSize = 12.1;
@@ -48,8 +39,9 @@ GlobalErrorBubble::GlobalErrorBubble(Browser* browser,
error_(error) {
DCHECK(browser_);
DCHECK(error_);
- GtkWidget* content = gtk_vbox_new(FALSE, kInterLineSpacing);
- gtk_container_set_border_width(GTK_CONTAINER(content), kContentBorder);
+ GtkWidget* content = gtk_vbox_new(FALSE, ui::kControlSpacing);
+ gtk_container_set_border_width(GTK_CONTAINER(content),
+ ui::kContentAreaBorder);
g_signal_connect(content, "destroy", G_CALLBACK(OnDestroyThunk), this);
GtkThemeService* theme_service =
@@ -79,7 +71,7 @@ GlobalErrorBubble::GlobalErrorBubble(Browser* browser,
}
// Top, icon and title.
- GtkWidget* top = gtk_hbox_new(FALSE, kImageViewSpacing);
+ GtkWidget* top = gtk_hbox_new(FALSE, ui::kControlSpacing);
gtk_box_pack_start(GTK_BOX(top), image_view, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(top), title_label, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(content), top, FALSE, FALSE, 0);
« no previous file with comments | « chrome/browser/ui/gtk/first_run_bubble.cc ('k') | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698