Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/ui/gtk/bubble/bubble_gtk.cc

Issue 10918275: [gtk] website settings bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fin Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/bubble/bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
index ead2517739f7af026d95e034c7c2e65364833ccc..92c4143240416d1c284f9258a38d232f41d0a433 100644
--- a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc
@@ -36,10 +36,10 @@ const int kArrowToContentPadding = -4;
const int kCornerSize = 3;
// Margins around the content.
-const int kTopMargin = kArrowSize + kCornerSize - 1;
-const int kBottomMargin = kCornerSize - 1;
-const int kLeftMargin = kCornerSize - 1;
-const int kRightMargin = kCornerSize - 1;
+const int kTopMargin = kArrowSize;
+const int kBottomMargin = 0;
+const int kLeftMargin = 0;
+const int kRightMargin = 0;
const GdkColor kBackgroundColor = GDK_COLOR_RGB(0xff, 0xff, 0xff);
const GdkColor kFrameColor = GDK_COLOR_RGB(0x63, 0x63, 0x63);
@@ -178,7 +178,9 @@ void BubbleGtk::Init(GtkWidget* anchor_widget,
gtk_widget_add_events(window_, GDK_BUTTON_PRESS_MASK);
- signals_.Connect(window_, "expose-event", G_CALLBACK(OnExposeThunk), this);
+ // Connect during the bubbling phase so the border is always on top.
+ signals_.ConnectAfter(window_, "expose-event",
+ G_CALLBACK(OnExposeThunk), this);
signals_.Connect(window_, "size-allocate", G_CALLBACK(OnSizeAllocateThunk),
this);
signals_.Connect(window_, "button-press-event",

Powered by Google App Engine
This is Rietveld 408576698