Cross-platform plumbing for resize-to-client

remoting/tools/me2me_virtual_host.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Virtual Me2Me implementation.  This script runs and manages the processes
 # required for a Virtual Me2Me desktop, which are: X server, X desktop
 # session, and Host process.
 # This script is intended to run continuously as a background daemon
 # process, running under an ordinary (non-root) user account.
@@ skipping 235 matching lines @@
     display = self.get_unused_display_number()
     ret_code = subprocess.call("xauth add :%d . `mcookie`" % display,
                                shell=True)
     if ret_code != 0:
       raise Exception("xauth failed with code %d" % ret_code)
 
     max_width = max([width for width, height in self.sizes])
     max_height = max([height for width, height in self.sizes])
 
     try:
-      xvfb = locate_executable("Xvfb-randr")
+      # TODO(jamiewalch): This script expects to be installed alongside
+      # Xvf-randr, but that's no longer the case. Fix this once we have

[Lambros, 2012/09/13 22:00:35]

typo: Xvfb-randr

[Jamie, 2012/09/14 21:07:34]

Done.

+      # a Xvfb-randr package that installs somewhere sensible.
+      xvfb = "/usr/bin/Xvfb-randr"

[Sergey Ulanov, 2012/09/13 20:52:43]

Not directly related to this CL: maybe we can just pack Xvfb-randr in our dpk
and put it in /opt/google/chrome-remote-desktop? That way we won't need to worry
about installing this dependency.

[Jamie, 2012/09/14 21:07:34]

Lambros had some reason for preferring to keep the two packages separate--he can
probably elaborate further, but it does seem like a cleaner way of doing it.

+      if not os.path.exists(xvfb):
+        xvfb = locate_executable("Xvfb-randr")
     except Exception:
       xvfb = "Xvfb"
 
     logging.info("Starting %s on display :%d" % (xvfb, display))
     screen_option = "%dx%dx24" % (max_width, max_height)
     self.x_proc = subprocess.Popen([xvfb, ":%d" % display,
                                     "-noreset",
                                     "-auth", X_AUTH_FILE,
                                     "-nolisten", "tcp",
                                     "-screen", "0", screen_option
@@ skipping 334 matching lines @@
 
 
 def main():
   DEFAULT_SIZE = "1280x800"
   EPILOG = """This script is not intended for use by end-users.  To configure
 Chrome Remote Desktop, please install the app from the Chrome
 Web Store: https://chrome.google.com/remotedesktop"""
   parser = optparse.OptionParser(
       usage="Usage: %prog [options] [ -- [ X server options ] ]",
       epilog=EPILOG)
   parser.add_option("-s", "--size", dest="size", action="append",

[rmsousa, 2012/09/13 21:59:05]

TODO: For this feature to be fully functional we need another way for users to
specify the maximum screen size (the default size is rather small, and with the
new /etc/init.d way it's hard to pass the size as a cmd line arg).

[Jamie, 2012/09/14 21:07:34]

I forgot to increase the default maximum size. You're right that we ought to
provide a way to change the default, but for now I'll just increase it.

                     help="Dimensions of virtual desktop (default: %s). "
                     "This can be specified multiple times to make multiple "
                     "screen resolutions available (if the Xvfb server "
                     "supports this)" % DEFAULT_SIZE)
   parser.add_option("-f", "--foreground", dest="foreground", default=False,
                     action="store_true",
                     help="Don't run as a background daemon.")
   parser.add_option("", "--start", dest="start", default=False,
                     action="store_true",
                     help="Start the host.")
@@ skipping 225 matching lines @@
         return 0
       elif os.WEXITSTATUS(status) == 5:
         logging.info("Host domain is blocked by policy - exiting.")
         os.remove(host.config_file)
         return 0
       # Nothing to do for Mac-only status 6 (login screen unsupported)
 
 if __name__ == "__main__":
   logging.basicConfig(level=logging.DEBUG)
   sys.exit(main())