Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java

Issue 10918154: Allow breakpoint enable and properties ruler actions for all breakpoints (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: spaces Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
index 9ea11cffeb354b85c97a883052a94c7286410570..842560970f84ebcad65de65528999c3f8a8fd3f0 100644
--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesAction.java
@@ -8,16 +8,14 @@ import org.chromium.debug.core.model.ChromiumExceptionBreakpoint;
import org.chromium.debug.core.model.ChromiumLineBreakpoint;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.jface.action.IAction;
+import org.eclipse.jface.preference.PreferenceDialog;
import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
-import org.eclipse.jface.viewers.ISelectionProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
-import org.eclipse.jface.viewers.StructuredSelection;
import org.eclipse.jface.window.IShellProvider;
import org.eclipse.ui.IObjectActionDelegate;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.IWorkbenchPartSite;
-import org.eclipse.ui.dialogs.PropertyDialogAction;
+import org.eclipse.ui.dialogs.PreferencesUtil;
/**
* Action to bring up the breakpoint properties dialog.
@@ -78,23 +76,10 @@ public abstract class JsBreakpointPropertiesAction implements IObjectActionDeleg
};
}
- protected static void runAction(final IBreakpoint breakpoint, IShellProvider shell) {
- PropertyDialogAction action =
- new PropertyDialogAction(shell,
- new ISelectionProvider() {
- public void addSelectionChangedListener(ISelectionChangedListener listener) {
- }
+ protected static void runAction(IBreakpoint breakpoint, IShellProvider shell) {
+ PreferenceDialog propertyDialog = PreferencesUtil.createPropertyDialogOn(
+ shell.getShell(), breakpoint, (String) null, (String[]) null, null);
- public ISelection getSelection() {
- return new StructuredSelection(breakpoint);
- }
-
- public void removeSelectionChangedListener(ISelectionChangedListener listener) {
- }
-
- public void setSelection(ISelection selection) {
- }
- });
- action.run();
+ propertyDialog.open();
}
}
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/JsBreakpointPropertiesRulerAction.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698