Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: build/android/ant/sdk-targets.xml

Issue 10918149: Use checked in keystore to sign debug apks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!-- 2 <!--
3 Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 <project name="chrome_sdk_overrides" > 7 <project name="chrome_sdk_overrides" >
8 <!-- 8 <!--
9 Redefinition of targets used by SDK tools. 9 Redefinition of targets used by SDK tools.
10 Supported version: SDK tools revision 20. 10 Supported version: SDK tools revision 20.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 outdir="${out.absolute.dir}/classes" 87 outdir="${out.absolute.dir}/classes"
88 verbosity="${verbosity}"> 88 verbosity="${verbosity}">
89 <filter excludes="${emma.default.filter}"/> 89 <filter excludes="${emma.default.filter}"/>
90 <filter value="${emma.filter}"/> 90 <filter value="${emma.filter}"/>
91 </instr> 91 </instr>
92 </emma> 92 </emma>
93 </then> 93 </then>
94 </if> 94 </if>
95 </do-only-if-manifest-hasCode> 95 </do-only-if-manifest-hasCode>
96 </target> 96 </target>
97
98 <!--
99 For debug builds, the Android SDK tools create a key in ~/.android and sign the build with it.
100 This has caused all kinds of issues. Instead, the debug build should be sign ed with a key in
101 build/android/ant. The SDK tools do not provide any support for overriding t hat behavior and so
102 instead one must use the hack below.
103 -->
104
105 <!-- Disables automatic signing. -->
106 <property name="build.is.signing.debug" value="false"/>
107
108 <!-- TODO(cjhopman): Remove this property when all gyp files define the CHROMI UM_SRC property. -->
109 <property name="CHROMIUM_SRC" value="${PRODUCT_DIR}/../.." />
110
111 <property name="key.store" value="${CHROMIUM_SRC}/build/android/ant/chrome-deb ug.keystore"/>
nilesh 2012/09/10 18:05:04 Please rename the key file to: chromium-apk-debug.
cjhopman 2012/09/10 18:21:41 Done. Also changed passwords and alias to chromium
Isaac (away) 2012/09/10 18:36:08 Did you intend to change this for patch set 2?
112 <property name="key.store.password" value="chrome"/>
113 <property name="key.alias" value="chromedebugkey"/>
114 <property name="key.alias.password" value="chrome"/>
115
116 <!-- SDK tools assume that out.packaged.file is signed and name it "...-unalig ned" -->
Isaac (away) 2012/09/10 18:17:25 line length
cjhopman 2012/09/10 18:21:41 We use 100 columns for ant build files.
117 <property name="out.packaged.file"
118 value="${out.dir}/${ant.project.name}-debug-unsigned.apk" />
119 <property name="out.unaligned.file"
120 value="${out.dir}/${ant.project.name}-debug-unaligned.apk" />
121
122 <!-- By default, the SDK tools build only aligns the APK in the -do-debug targ et. -->
Isaac (away) 2012/09/10 18:17:25 line length
123 <target name="-do-debug" depends="-set-debug-mode, -debug-obfuscation-check, - package, -post-package">
nilesh 2012/09/10 18:05:04 This does not fit in 100 chars. Please add a line
cjhopman 2012/09/10 18:21:41 Done.
124 <!-- only create apk if *not* a library project -->
125 <do-only-if-not-library elseText="Library project: do not create apk..." >
126 <sequential>
127 <!-- Signs the APK -->
128 <echo level="info">Signing final apk...</echo>
129 <signapk
130 input="${out.packaged.file}"
131 output="${out.unaligned.file}"
132 keystore="${key.store}"
133 storepass="${key.store.password}"
134 alias="${key.alias}"
135 keypass="${key.alias.password}"/>
136
137 <!-- Zip aligns the APK -->
138 <zipalign-helper
139 in.package="${out.unaligned.file}"
140 out.package="${out.final.file}" />
141 <echo level="info">Release Package: ${out.final.file}</echo>
142 </sequential>
143 </do-only-if-not-library>
144 <record-build-info />
145 </target>
97 </project> 146 </project>
OLDNEW
« no previous file with comments | « build/android/ant/chrome-debug.keystore ('k') | content/shell/android/java/content_shell_apk.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698