chrome/browser/download/chrome_download_manager_delegate.cc - Issue 10918136: Make web store resilient against download completion happening before opening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 10918136: Make web store resilient against download completion happening before opening. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comment. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/chrome_download_manager_delegate.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc

index 528520cca56f5f5738c2a41d3ae1c7ba98965197..93c0c837a3681135561ed76b00b87964f762b44e 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate.cc

@@ -689,7 +689,7 @@ void ChromeDownloadManagerDelegate::Observe(

int download_id = crx_installers_[installer];

crx_installers_.erase(installer.get());

- DownloadItem* item = download_manager_->GetActiveDownloadItem(download_id);

+ DownloadItem* item = download_manager_->GetDownload(download_id);

if (item)

item->DelayedDownloadOpened(installer->did_handle_successfully());

}

« no previous file with comments | « no previous file | chrome/browser/download/download_browsertest.cc » ('j') | no next file with comments »