Make web store resilient against download completion happening before opening.

content/public/test/download_test_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_DOWNLOAD_TEST_OBSERVER_H_
 #define CONTENT_TEST_DOWNLOAD_TEST_OBSERVER_H_
 
 #include <set>
 #include <vector>
 
 #include "base/basictypes.h"
+#include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/download_url_parameters.h"
 #include "net/base/net_errors.h"
 
 namespace content {
 
+// Detects an arbitrary change on a download item.
+// TODO: Rewrite other observers to use this (or be replaced by it).
+class DownloadUpdatedObserver : public DownloadItem::Observer {
+ public:
+  typedef base::Callback<bool(DownloadItem*)> EventFilter;

[benjhayden, 2012/09/10 14:48:52]

Comment that this may be called multiple times? And may even be called after it
returns true?

[Randy Smith (Not in Mondays), 2012/09/10 17:16:42]

Done.

+
+  DownloadUpdatedObserver(DownloadItem* item, EventFilter filter);
+  ~DownloadUpdatedObserver();
+
+  // Returns false if the waiting ended because of the destruction of the
+  // DownloadItem rather than because of the expected event occuring.
+  bool WaitForEvent();
+
+ private:
+  // DownloadItem::Observer
+  void OnDownloadUpdated(DownloadItem* item) OVERRIDE;
+  void OnDownloadDestroyed(DownloadItem* item) OVERRIDE;
+
+  DownloadItem* item_;
+  EventFilter filter_;
+  bool waiting_;
+};

[benjhayden, 2012/09/10 14:48:52]

DISALLOW_COPY_AND_ASSIGN?

[Randy Smith (Not in Mondays), 2012/09/10 17:16:42]

Done.

+
 // Detects changes to the downloads after construction.
 // Finishes when one of the following happens:
 //   - A specified number of downloads change to a terminal state (defined
 //     in derived classes).
 //   - Specific events, such as a select file dialog.
 // Callers may either probe for the finished state, or wait on it.
 //
 // TODO(rdsmith): Detect manager going down, remove pointer to
 // DownloadManager, transition to finished.  (For right now we
 // just use a scoped_refptr<> to keep it around, but that may cause
@@ skipping 224 matching lines @@
 
   // We are in the message loop.
   bool waiting_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadTestItemCreationObserver);
 };
 
 }  // namespace content`
 
 #endif  // CONTENT_TEST_DOWNLOAD_TEST_OBSERVER_H_