Check the return value of API calls on ia32 and x64.

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index e3c40fdfe12990aa7bc9426626e10f24da181c3a..a96e3b78e150a1e8353d712c47d6c7f8d481db7f 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -210,7 +210,20 @@ MaybeObject* JSObject::GetPropertyWithCallback(Object* receiver,
     if (result.IsEmpty()) {
       return isolate->heap()->undefined_value();
     }
-    return *v8::Utils::OpenHandle(*result);
+    Object* return_value = *v8::Utils::OpenHandle(*result);
+#if 1

[Jakob Kummerow, 2012/09/05 14:08:51]

#if ENABLE_EXTRA_CHECKS maybe?

[Sven Panne, 2012/09/05 14:11:47]

Done.

+    if (!(return_value->IsSmi() ||
+          return_value->IsString() ||
+          return_value->IsSpecObject() ||
+          return_value->IsHeapNumber() ||
+          return_value->IsUndefined() ||
+          return_value->IsTrue() ||
+          return_value->IsFalse() ||
+          return_value->IsNull())) {
+      FATAL("API call returned invalid object");
+    }
+#endif
+    return return_value;
   }
 
   // __defineGetter__ callback