Fix up views web intents location bar decoration.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 140 matching lines @@
   IDR_OMNIBOX_EV_BUBBLE_BACKGROUND_C,
   IDR_OMNIBOX_EV_BUBBLE_BACKGROUND_R,
 };
 
 static const int kSelectedKeywordBackgroundImages[] = {
   IDR_LOCATION_BAR_SELECTED_KEYWORD_BACKGROUND_L,
   IDR_LOCATION_BAR_SELECTED_KEYWORD_BACKGROUND_C,
   IDR_LOCATION_BAR_SELECTED_KEYWORD_BACKGROUND_R,
 };
 
-// TODO(gbillock): replace these with web-intents images when available.
 static const int kWIBubbleBackgroundImages[] = {
   IDR_OMNIBOX_WI_BUBBLE_BACKGROUND_L,
   IDR_OMNIBOX_WI_BUBBLE_BACKGROUND_C,
   IDR_OMNIBOX_WI_BUBBLE_BACKGROUND_R,
 };
 
 #if defined(USE_AURA)
 LocationBarView::FadeAnimationObserver::FadeAnimationObserver(
     LocationBarView* location_bar_view)
     : location_bar_view_(location_bar_view) {
@@ skipping 112 matching lines @@
 
   keyword_hint_view_ = new KeywordHintView(profile_);
   AddChildView(keyword_hint_view_);
   keyword_hint_view_->SetVisible(false);
   keyword_hint_view_->SetFont(font_);
 
   for (int i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {
     ContentSettingImageView* content_blocked_view =
         new ContentSettingImageView(static_cast<ContentSettingsType>(i),
                                     kCSBubbleBackgroundImages, this);
+    content_blocked_view->SetFont(font_);
+    content_blocked_view->SetFontColor(GetColor(ToolbarModel::NONE, TEXT));

[Peter Kasting, 2012/09/17 20:04:27]

Can we just pass the font and color to the constructor?  Then we omit the need
for accessors entirely.  (2 places)

[Greg Billock, 2012/09/17 21:23:18]

Done.

     content_setting_views_.push_back(content_blocked_view);
     AddChildView(content_blocked_view);
     content_blocked_view->SetVisible(false);
   }
 
   zoom_view_ = new ZoomView(model_, delegate_);
   AddChildView(zoom_view_);
 
   web_intents_button_view_ =
       new WebIntentsButtonView(this, kWIBubbleBackgroundImages);
+  web_intents_button_view_->SetFont(font_);
+  web_intents_button_view_->SetFontColor(GetColor(ToolbarModel::NONE, TEXT));
   AddChildView(web_intents_button_view_);
 
   if (browser_defaults::bookmarks_enabled && (mode_ == NORMAL)) {
     // Note: condition above means that the star icon is hidden in popups and in
     // the app launcher.
     star_view_ = new StarView(command_updater_);
     AddChildView(star_view_);
     star_view_->SetVisible(true);
   }
   if (extensions::switch_utils::IsActionBoxEnabled() && browser_) {
@@ skipping 394 matching lines @@
        i != page_action_views_.end(); ++i) {
     if ((*i)->visible())
       entry_width -= ((*i)->GetPreferredSize().width() + GetItemPadding());
   }
   if (zoom_view_->visible())
     entry_width -= zoom_view_->GetPreferredSize().width() + GetItemPadding();
   for (ContentSettingViews::const_iterator i(content_setting_views_.begin());
        i != content_setting_views_.end(); ++i) {
     if ((*i)->visible())
       entry_width -= ((*i)->GetPreferredSize().width() + GetItemPadding());
   }

[Greg Billock, 2012/09/15 14:29:12]

Note to self: missing entry_width adjustment here! bug 149756

[Peter Kasting, 2012/09/17 20:04:27]

Indeed.

   // The gap between the edit and whatever is to its right is shortened.
   entry_width += kEditInternalSpace;
 
   // Size the EV bubble after taking star/page actions/content settings out of
   // |entry_width| so we won't take too much space.
   if (ev_bubble_width) {
     // Try to elide the bubble to be no larger than half the total available
     // space, but never elide it any smaller than 150 px.
     static const int kMinElidedBubbleWidth = 150;
     static const double kMaxBubbleFraction = 0.5;
@@ skipping 86 matching lines @@
       offset -= GetItemPadding() - (*i)->GetBuiltInHorizontalPadding();
     }
   }
 
   // Now the web intents button
   if (web_intents_button_view_->visible()) {
     offset += web_intents_button_view_->GetBuiltInHorizontalPadding();
     int width = web_intents_button_view_->GetPreferredSize().width();
     offset -= width;
     web_intents_button_view_->SetBounds(
-        offset, location_y, width, location_height);
+        offset, location_y + kBubbleVerticalPadding, width,
+        web_intents_button_view_->GetPreferredSize().height());
     offset -= GetItemPadding() -
               web_intents_button_view_->GetBuiltInHorizontalPadding();
   }
 
   // Now lay out items to the left of the edit field.
   if (location_icon_view_->visible()) {
     location_icon_view_->SetBounds(
         kEdgeThickness + GetEdgeItemPadding() -
         location_icon_view_->GetBuiltInHorizontalPadding(),
         location_y, location_icon_width, location_height);
@@ skipping 715 matching lines @@
 }
 
 void LocationBarView::CleanupFadeAnimation() {
   // Since we're no longer animating we don't need our layer.
   SetPaintToLayer(false);
   // Bubble labels don't need a transparent background anymore.
   ev_bubble_view_->SetLabelBackgroundColor(SK_ColorWHITE);
   selected_keyword_view_->SetLabelBackgroundColor(SK_ColorWHITE);
 }
 #endif  // USE_AURA