Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10917278: Remove mouse lock / pointer lock flags. (Closed)

Created:
8 years, 3 months ago by scheib
Modified:
8 years, 3 months ago
Reviewers:
jamesr, yzshen1, sky, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, scheib+watch_chromium.org, jam
Visibility:
Public.

Description

Remove mouse lock / pointer lock flags. BUG=137172 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157381

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M chrome/browser/about_flags.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
scheib
8 years, 3 months ago (2012-09-17 16:02:18 UTC) #1
yzshen1
lgtm
8 years, 3 months ago (2012-09-17 16:55:35 UTC) #2
scheib
OWNERS please: chrome/browser - sky content/public - joi chrome - sky content/renderer - jamesr
8 years, 3 months ago (2012-09-17 19:22:20 UTC) #3
jamesr
content/renderer lgtm http://codereview.chromium.org/10917278/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): http://codereview.chromium.org/10917278/diff/1/content/renderer/render_thread_impl.cc#newcode661 content/renderer/render_thread_impl.cc:661: WebKit::WebRuntimeFeatures::enablePointerLock(true); is there a corresponding WebKit bug ...
8 years, 3 months ago (2012-09-17 19:27:00 UTC) #4
Jói
LGTM for content/public. On Mon, Sep 17, 2012 at 7:27 PM, <jamesr@chromium.org> wrote: > content/renderer ...
8 years, 3 months ago (2012-09-17 19:52:57 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-17 20:55:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/10917278/1
8 years, 3 months ago (2012-09-18 15:27:03 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 18:03:54 UTC) #8
Change committed as 157381

Powered by Google App Engine
This is Rietveld 408576698