Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10917251: Move TextureCopier and TextureUploader from CCRenderer to CCResourceProvider (Closed)

Created:
8 years, 3 months ago by piman
Modified:
8 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, danakj, aelias_OOO_until_Jul13
Visibility:
Public.

Description

Move TextureCopier and TextureUploader from CCRenderer to CCResourceProvider These don't really belong to the CCRenderer, and this way we share a bit more between renderers. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157289

Patch Set 1 : rebase #

Patch Set 2 : fix OVERRIDE #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : fix rebase merge issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -96 lines) Patch
M cc/CCLayerTreeHostImpl.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCPrioritizedTextureTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderer.h View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M cc/CCRendererGL.h View 1 2 3 5 chunks +2 lines, -10 lines 0 comments Download
M cc/CCRendererGL.cpp View 1 2 3 6 chunks +3 lines, -16 lines 0 comments Download
M cc/CCResourceProvider.h View 1 2 3 5 chunks +11 lines, -2 lines 0 comments Download
M cc/CCResourceProvider.cpp View 1 2 3 6 chunks +22 lines, -4 lines 0 comments Download
M cc/CCResourceProviderTest.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCScopedTextureTest.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M cc/CCSingleThreadProxy.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/CCTextureUpdateController.h View 1 2 3 4 5 4 chunks +4 lines, -6 lines 0 comments Download
M cc/CCTextureUpdateController.cpp View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 2 3 4 5 24 chunks +25 lines, -26 lines 0 comments Download
M cc/CCThreadProxy.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/compositor_bindings/TiledLayerChromiumTest.cpp View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
piman
8 years, 3 months ago (2012-09-14 03:17:12 UTC) #1
jamesr
lgtm
8 years, 3 months ago (2012-09-14 20:50:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/3006
8 years, 3 months ago (2012-09-14 22:23:58 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/CCTextureUpdateControllerTest.cpp: While running patch -p1 --forward --force; patching file cc/CCTextureUpdateControllerTest.cpp ...
8 years, 3 months ago (2012-09-14 22:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/10002
8 years, 3 months ago (2012-09-14 22:25:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for cc/CCTextureUpdateControllerTest.cpp: While running patch -p1 --forward --force; patching file cc/CCTextureUpdateControllerTest.cpp ...
8 years, 3 months ago (2012-09-14 22:25:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/10002
8 years, 3 months ago (2012-09-15 01:21:32 UTC) #7
commit-bot: I haz the power
Failed to apply patch for cc/CCTextureUpdateControllerTest.cpp: While running patch -p1 --forward --force; patching file cc/CCTextureUpdateControllerTest.cpp ...
8 years, 3 months ago (2012-09-15 01:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/9004
8 years, 3 months ago (2012-09-17 21:26:01 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 21:37:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/9004
8 years, 3 months ago (2012-09-17 21:43:17 UTC) #11
commit-bot: I haz the power
Failed to apply patch for cc/CCTextureUpdateController.cpp: While running patch -p1 --forward --force; patching file cc/CCTextureUpdateController.cpp ...
8 years, 3 months ago (2012-09-17 23:41:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/14005
8 years, 3 months ago (2012-09-17 23:54:01 UTC) #13
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-18 00:11:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10917251/6037
8 years, 3 months ago (2012-09-18 00:11:22 UTC) #15
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 03:44:59 UTC) #16
Change committed as 157289

Powered by Google App Engine
This is Rietveld 408576698