Chromium Code Reviews| Index: net/udp/udp_socket_libevent.cc |
| diff --git a/net/udp/udp_socket_libevent.cc b/net/udp/udp_socket_libevent.cc |
| index beb1dcaf87d896064cf6f4ce8220442b94f31a18..a0be9d938403900dda7a8b7d4b6412583fe75adc 100644 |
| --- a/net/udp/udp_socket_libevent.cc |
| +++ b/net/udp/udp_socket_libevent.cc |
| @@ -465,16 +465,17 @@ int UDPSocketLibevent::SetSocketOptions() { |
| sizeof(true_value)); |
| if (rv < 0) |
| return MapSystemError(errno); |
| -#if defined(SO_REUSEPORT) |
| + } |
| + if (socket_options_ & SOCKET_OPTION_BROADCAST) { |
| + int rv; |
| +#if defined(OS_MACOSX) && defined(SO_REUSEPORT) |
|
Sergey Ulanov
2012/09/14 19:38:45
You don't need defined(SO_REUSEPORT) here - we exp
ygorshenin1
2012/09/18 11:34:05
Done.
|
| rv = setsockopt(socket_, SOL_SOCKET, SO_REUSEPORT, &true_value, |
|
Sergey Ulanov
2012/09/14 19:38:45
Please add comments here to explain why we need th
ygorshenin1
2012/09/18 11:34:05
Done.
|
| sizeof(true_value)); |
| if (rv < 0) |
| return MapSystemError(errno); |
| -#endif |
| - } |
| - if (socket_options_ & SOCKET_OPTION_BROADCAST) { |
| - int rv = setsockopt(socket_, SOL_SOCKET, SO_BROADCAST, &true_value, |
| - sizeof(true_value)); |
| +#endif // defined(OS_MACOSX) && defined(SO_REUSEPORT) |
| + rv = setsockopt(socket_, SOL_SOCKET, SO_BROADCAST, &true_value, |
| + sizeof(true_value)); |
| if (rv < 0) |
| return MapSystemError(errno); |
| } |