sync/sessions/sync_session_unittest.cc - Issue 10917234: sync: make scheduling logic and job ownership more obvious.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/sessions/sync_session_unittest.cc

Issue 10917234: sync: make scheduling logic and job ownership more obvious. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test + comment + rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/sessions/sync_session_unittest.cc

diff --git a/sync/sessions/sync_session_unittest.cc b/sync/sessions/sync_session_unittest.cc

index bc69fe87588f615a9cc8846a4e395b8301c6722c..22ded5082b57dfc5da27aa459c8fc1af5b7a04e4 100644

--- a/sync/sessions/sync_session_unittest.cc

+++ b/sync/sessions/sync_session_unittest.cc

@@ -368,7 +368,7 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestRemoveOneType) {

EXPECT_EQ(expected_enabled_groups_one, one.GetEnabledGroups());

EXPECT_EQ(expected_enabled_groups_two, two.GetEnabledGroups());

- two.RebaseRoutingInfoWithLatest(one);

+ two.RebaseRoutingInfoWithLatest(one.routing_info(), one.workers());

EXPECT_EQ(expected_enabled_groups_one, one.GetEnabledGroups());

EXPECT_EQ(expected_enabled_groups_one, two.GetEnabledGroups());

@@ -438,7 +438,7 @@ TEST_F(SyncSessionTest, RebaseRoutingInfoWithLatestWithSameType) {

EXPECT_EQ(expected_enabled_groups, first.GetEnabledGroups());

EXPECT_EQ(expected_enabled_groups, second.GetEnabledGroups());

- second.RebaseRoutingInfoWithLatest(first);

+ second.RebaseRoutingInfoWithLatest(first.routing_info(), first.workers());

EXPECT_EQ(expected_enabled_groups, first.GetEnabledGroups());

EXPECT_EQ(expected_enabled_groups, second.GetEnabledGroups());