Remove PluginFinder async interface

Remove PluginFinder async interface

Depends on this CL: http://codereview.chromium.org/10910168/

BUG=124396
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158799

[Bernhard Bauer, 2012-09-17 15:19:48]

lgtm

[ibraaaa, 2012-09-21 16:00:42]

Hi Peter & James,

Can I have an OWNERS review for this CL?

-Peter for chrome/browser/ui/
-James for chrome/browser/pepper_broker_observer.cc

Thanks!

[Peter Kasting, 2012-09-21 20:10:56]

The fact that three platforms duplicate the same code to get plugin names kind
of sucks... consider taking a followon task to refactor some of this stuff if
possible

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/cocoa/co...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
(right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/cocoa/co...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:256:
NSString* name = nil;
Nit: Or just

      NSString* name = plugin ? SysUTF16ToNSString(plugin->name() : nil;

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/gtk/cont...
File chrome/browser/ui/gtk/content_setting_bubble_gtk.cc (right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/gtk/cont...
chrome/browser/ui/gtk/content_setting_bubble_gtk.cc:117: std::string name;
Nit: Or

      std::string name(plugin ? UTF16ToUTF8(plugin->name()) : std::string());

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/views/co...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/views/co...
chrome/browser/ui/views/content_setting_bubble_contents.cc:161: string16 name;
Nit: See comment in GTK

[Peter Kasting, 2012-09-21 20:11:04]

Oh, LGTM (forgot)

[ibraaaa, 2012-09-24 11:42:29]

Bernhard, PTAL.

Thanks!

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/cocoa/co...
File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
(right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/cocoa/co...
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:256:
NSString* name = nil;
On 2012/09/21 20:10:56, Peter Kasting wrote:
> Nit: Or just
> 
>       NSString* name = plugin ? SysUTF16ToNSString(plugin->name() : nil;

Done.

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/gtk/cont...
File chrome/browser/ui/gtk/content_setting_bubble_gtk.cc (right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/gtk/cont...
chrome/browser/ui/gtk/content_setting_bubble_gtk.cc:117: std::string name;
On 2012/09/21 20:10:56, Peter Kasting wrote:
> Nit: Or
> 
>       std::string name(plugin ? UTF16ToUTF8(plugin->name()) : std::string());

Done.

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/views/co...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

http://codereview.chromium.org/10917189/diff/14001/chrome/browser/ui/views/co...
chrome/browser/ui/views/content_setting_bubble_contents.cc:161: string16 name;
On 2012/09/21 20:10:56, Peter Kasting wrote:
> Nit: See comment in GTK

Done.

[ibraaaa, 2012-09-25 17:55:18]

Hi James,

Can I have an OWNERS review for this file:
chrome/browser/pepper_broker_observer.cc ?

[James Hawkins, 2012-09-25 17:59:05]

lgtm

[commit-bot: I haz the power, 2012-09-26 06:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@google.com/10917189/31001

[commit-bot: I haz the power, 2012-09-26 06:20:48]

Failed to apply patch for chrome/browser/plugins/plugin_observer.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/plugins/plugin_observer.cc
Hunk #2 FAILED at 243.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/plugins/plugin_observer.cc.rej

[commit-bot: I haz the power, 2012-09-26 09:30:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@google.com/10917189/34001

[commit-bot: I haz the power, 2012-09-26 09:35:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@google.com/10917189/33004

[commit-bot: I haz the power, 2012-09-26 13:46:12]

Retried try job too often for step(s) remoting_unittests

[commit-bot: I haz the power, 2012-09-26 13:52:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@google.com/10917189/33004

[commit-bot: I haz the power, 2012-09-26 14:32:25]

Change committed as 158799