Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10917150: Softoken interface for AES_CTR AES_CTS and AES_GCM. (Closed)

Created:
8 years, 3 months ago by wtc
Modified:
8 years, 1 month ago
Reviewers:
rjrejyea, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Softoken interface for AES_CTR AES_CTS and AES_GCM. This is Bob Relyea's NSS softoken patch https://bug373108.bugzilla.mozilla.org/attachment.cgi?id=658669 imported into Rietveld for code review. R=rsleevi@chromium.org BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Move lib/util/pkcs11t.h from this CL to the freebl CL #

Total comments: 12

Patch Set 3 : Remove the residual context->end() changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M nss/mozilla/security/nss/lib/softoken/pkcs11.c View 2 chunks +5 lines, -2 lines 0 comments Download
M nss/mozilla/security/nss/lib/softoken/pkcs11c.c View 1 2 3 chunks +23 lines, -1 line 0 comments Download
M nss/mozilla/security/nss/lib/softoken/pkcs11i.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M nss/mozilla/security/nss/lib/softoken/pkcs11u.c View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
Patch set 1 is Bob Relyea's patch.
8 years, 3 months ago (2012-09-07 22:42:37 UTC) #1
wtc
Review comments on patch set 2: I don't understand why the changes related to context->end ...
8 years, 3 months ago (2012-09-18 01:53:38 UTC) #2
rjrejyea
http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/lib/softoken/pkcs11.c File nss/mozilla/security/nss/lib/softoken/pkcs11.c (right): http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/lib/softoken/pkcs11.c#newcode382 nss/mozilla/security/nss/lib/softoken/pkcs11.c:382: {CKM_AES_GCM, {16, 32, CKF_EN_DE}, PR_TRUE}, Especially since we didn't ...
8 years, 3 months ago (2012-09-19 23:30:15 UTC) #3
rjrejyea
http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/lib/softoken/pkcs11i.h File nss/mozilla/security/nss/lib/softoken/pkcs11i.h (right): http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/lib/softoken/pkcs11i.h#newcode148 nss/mozilla/security/nss/lib/softoken/pkcs11i.h:148: typedef SECStatus (*SFTKEnd)(void *,void *,unsigned int *,unsigned int); This ...
8 years, 3 months ago (2012-09-19 23:31:35 UTC) #4
wtc
8 years, 3 months ago (2012-09-24 16:55:17 UTC) #5
Bob: thank you for your reply. Please review patch set 3.

I removed the changes related to context->end().

Tips for using the code review tool:

1. I recommend reviewing the "Side-by-side diffs" rather
than the "Unified diffs".

2. To see the delta from patch set 2 (which you reviewed
last time), click the links labeled "2" under the "Delta
from patch set" column.

http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/li...
File nss/mozilla/security/nss/lib/softoken/pkcs11c.c (right):

http://codereview.chromium.org/10917150/diff/7001/nss/mozilla/security/nss/li...
nss/mozilla/security/nss/lib/softoken/pkcs11c.c:822: (unsigned
char*)pMechanism->pParameter,

I also removed the space that was added at the end of the line
accidentally.  Note that it is usually easy to see white space
changes in this code review tool.

Powered by Google App Engine
This is Rietveld 408576698