chrome/browser/history/thumbnail_database.h - Issue 10917041: Cleanup FaviconSQLHandler::Update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/thumbnail_database.h

Issue 10917041: Cleanup FaviconSQLHandler::Update (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved changes to thumbnail_database to http://codereview.chromium.org/10911149/ Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/thumbnail_database.h

diff --git a/chrome/browser/history/thumbnail_database.h b/chrome/browser/history/thumbnail_database.h

index a3cf663a6342ce71e976155fd320050f8322f1d7..10a8198c9cfc810bbc70a8eff2d00e4358550ed6 100644

--- a/chrome/browser/history/thumbnail_database.h

+++ b/chrome/browser/history/thumbnail_database.h

@@ -204,6 +204,10 @@ class ThumbnailDatabase {

// Returns true if the deletion succeeded.

bool DeleteIconMappings(const GURL& page_url);

+ // Deletes the icon mapping with |mapping_id|.

+ // Returns true if the deletion succeeded.

+ bool DeleteIconMapping(IconMappingID mapping_id);

// Checks whether a favicon is used by any URLs in the database.

bool HasMappingFor(FaviconID id);