Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: webkit/quota/quota_manager.cc

Issue 10916313: Cleanup: quota::HostUsageCallback and quota::HostQuotaCallback do not need to pass host and type as… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/quota/quota_manager_unittest.cc » ('j') | webkit/quota/quota_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/quota/quota_manager.cc
diff --git a/webkit/quota/quota_manager.cc b/webkit/quota/quota_manager.cc
index 095c24d7f0f0afed701a4d65fccc675a9309d6d7..1b2be0484057b2112269532564c167c142f5d28a 100644
--- a/webkit/quota/quota_manager.cc
+++ b/webkit/quota/quota_manager.cc
@@ -354,10 +354,11 @@ class QuotaManager::UsageAndQuotaDispatcherTask : public QuotaTask {
return base::Bind(&UsageAndQuotaDispatcherTask::DidGetGlobalUsage,
weak_factory_.GetWeakPtr());
}
- HostUsageCallback NewWaitableHostUsageCallback() {
+ HostUsageCallback NewWaitableHostUsageCallback(const std::string& host,
+ quota::StorageType type) {
++waiting_callbacks_;
return base::Bind(&UsageAndQuotaDispatcherTask::DidGetHostUsage,
- weak_factory_.GetWeakPtr());
+ weak_factory_.GetWeakPtr(), host, type);
kinuko 2012/09/17 19:15:42 looks like we can call host() and type() here rath
calvinlo 2012/09/18 05:59:18 Done.
}
HostQuotaCallback NewWaitableHostQuotaCallback() {
++waiting_callbacks_;
@@ -480,7 +481,7 @@ class QuotaManager::UsageAndQuotaDispatcherTaskForTemporary
manager()->GetUsageTracker(type())->GetGlobalUsage(
NewWaitableGlobalUsageCallback());
manager()->GetUsageTracker(type())->GetHostUsage(
- host(), NewWaitableHostUsageCallback());
+ host(), NewWaitableHostUsageCallback(host(), type()));
manager()->GetAvailableSpace(NewWaitableAvailableSpaceCallback());
}
@@ -512,7 +513,7 @@ class QuotaManager::UsageAndQuotaDispatcherTaskForPersistent
protected:
virtual void RunBody() OVERRIDE {
manager()->GetUsageTracker(type())->GetHostUsage(
- host(), NewWaitableHostUsageCallback());
+ host(), NewWaitableHostUsageCallback(host(), type()));
manager()->GetPersistentHostQuota(
host(), NewWaitableHostQuotaCallback());
manager()->GetAvailableSpace(NewWaitableAvailableSpaceCallback());
@@ -535,7 +536,7 @@ class QuotaManager::UsageAndQuotaDispatcherTaskForSyncable
protected:
virtual void RunBody() OVERRIDE {
manager()->GetUsageTracker(type())->GetHostUsage(
- host(), NewWaitableHostUsageCallback());
+ host(), NewWaitableHostUsageCallback(host(), type()));
}
virtual void DispatchCallbacks() OVERRIDE {
« no previous file with comments | « no previous file | webkit/quota/quota_manager_unittest.cc » ('j') | webkit/quota/quota_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698