Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: android_webview/lib/aw_browser_dependency_factory_impl.cc

Issue 10916309: [Android] Remove the dependency on TabContents. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/lib/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/aw_browser_dependency_factory_impl.cc
diff --git a/android_webview/lib/aw_browser_dependency_factory_impl.cc b/android_webview/lib/aw_browser_dependency_factory_impl.cc
index f31bb64e7971921c0621145bfd3b64042f4b2cb7..41e78c8c3e761c433520aa21e6966fb4a398e714 100644
--- a/android_webview/lib/aw_browser_dependency_factory_impl.cc
+++ b/android_webview/lib/aw_browser_dependency_factory_impl.cc
@@ -15,7 +15,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "content/public/browser/web_contents.h"
#include "ipc/ipc_message.h"
#include "net/url_request/url_request_context.h"
@@ -30,21 +29,21 @@ namespace {
base::LazyInstance<AwBrowserDependencyFactoryImpl>::Leaky g_lazy_instance;
-class TabContentsWrapper : public AwContentsContainer {
+class WebContentsWrapper : public AwContentsContainer {
public:
- TabContentsWrapper(TabContents* tab_contents) {
- tab_contents_.reset(tab_contents);
+ WebContentsWrapper(WebContents* web_contents)
+ : web_contents_(web_contents) {
}
- virtual ~TabContentsWrapper() {}
+ virtual ~WebContentsWrapper() {}
// AwContentsContainer
virtual content::WebContents* GetWebContents() OVERRIDE {
- return tab_contents_->web_contents();
+ return web_contents_.get();
}
private:
- scoped_ptr<TabContents> tab_contents_;
+ scoped_ptr<content::WebContents> web_contents_;
};
} // namespace
@@ -100,8 +99,7 @@ WebContents* AwBrowserDependencyFactoryImpl::CreateWebContents(bool incognito) {
AwContentsContainer* AwBrowserDependencyFactoryImpl::CreateContentsContainer(
content::WebContents* contents) {
- return new TabContentsWrapper(
- TabContents::Factory::CreateTabContents(contents));
Avi (use Gerrit) 2012/09/14 20:36:00 Thank you. Please remove the friend declaration fr
+ return new WebContentsWrapper(contents);
}
content::JavaScriptDialogCreator*
« no previous file with comments | « android_webview/lib/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698