content/browser/download/download_manager_impl.cc - Issue 10916201: Make the SavePackage use of the fake download item cleaner around cancellation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 10916201: Make the SavePackage use of the fake download item cleaner around cancellation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged to LKGR (156083) Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/download_manager_impl.cc

diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc

index 315d6439e2f7da52743977e550c6213437a49228..266602f92f1e01745f2abc017c7381dbb4e23123 100644

--- a/content/browser/download/download_manager_impl.cc

+++ b/content/browser/download/download_manager_impl.cc

@@ -1020,11 +1020,6 @@ void DownloadManagerImpl::SavePageDownloadFinished(

if (download->IsPersisted()) {

if (delegate_)

delegate_->UpdateItemInPersistentStore(download);

- if (download->IsComplete())

- content::NotificationService::current()->Notify(

- content::NOTIFICATION_SAVE_PACKAGE_SUCCESSFULLY_FINISHED,

- content::Source<DownloadManager>(this),

- content::Details<DownloadItem>(download));

}

« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »