Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_data_source.h

Issue 10916182: Refactor the about:version code out of about_ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: more estade changes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/chrome_web_ui_data_source.cc » ('j') | chrome/browser/ui/webui/version_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_ui_data_source.h
===================================================================
--- chrome/browser/ui/webui/chrome_web_ui_data_source.h (revision 155736)
+++ chrome/browser/ui/webui/chrome_web_ui_data_source.h (working copy)
@@ -24,6 +24,9 @@
// Adds a string and its equivalent to our dictionary.
Evan Stade 2012/09/14 15:11:30 this comment doesn't make sense to me, does it mak
SteveT 2012/09/14 15:28:37 Let me know if this correction seems better.
void AddString(const std::string& name, const string16& value);
+ // Adds a string and its equivalent to our dictionary.
+ void AddString(const std::string& name, const std::string& value);
+
// Adds a name and its equivaled localized string to our dictionary.
Evan Stade 2012/09/14 15:11:30 this one almost makes sense except for "equivaled"
SteveT 2012/09/14 15:28:37 Ditto
void AddLocalizedString(const std::string& name, int ids);
« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/chrome_web_ui_data_source.cc » ('j') | chrome/browser/ui/webui/version_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698