Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2932)

Unified Diff: chrome/browser/resources/about_version.html

Issue 10916182: Refactor the about:version code out of about_ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Win fixes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/about_version.html
===================================================================
--- chrome/browser/resources/about_version.html (revision 155736)
+++ chrome/browser/resources/about_version.html (working copy)
@@ -14,6 +14,8 @@
<if expr="pp_ifdef('android')">
<link rel="stylesheet" href="about_version_android.css">
</if>
+ <script src="chrome://resources/js/cr.js"></script>
+ <script src="chrome://resources/js/load_time_data.js"></script>
<script src="chrome://resources/js/parse_html_subset.js"></script>
<script src="chrome://resources/js/util.js"></script>
<script src="chrome://version/version.js"></script>
@@ -34,22 +36,34 @@
</div>
<table id="inner" cellpadding="0" cellspacing="0" border="0">
<tr><td class="label" valign="top" id="name" i18n-content="name"></td>
- <td class="version" id="version"><span i18n-content="version"></span> (<span i18n-content="official"></span> <span i18n-content="cl"></span>) <span i18n-content="version_modifier"></span></td>
+ <td class="version" id="version">
+ <span i18n-content="version"></span>
+ (<span i18n-content="official"></span> <span i18n-content="cl"></span>)
Evan Stade 2012/09/14 09:18:02 you can put a line return in between </span> and <
SteveT 2012/09/14 14:48:15 Done.
+ <span i18n-content="version_modifier"></span>
+ </td>
</tr>
<if expr="not pp_ifdef('chromeos')">
<tr><td class="label" valign="top" i18n-content="os_name"></td>
- <td class="version" id="os_type"><span i18n-content="os_type"></span> <span i18n-content="os_version"></span></td>
+ <td class="version" id="os_type">
+ <span i18n-content="os_type"></span>
+ <span id="os_version" i18n-content="os_version"></span>
+ </td>
</if>
<if expr="pp_ifdef('chromeos')">
<tr><td class="label" valign="top" i18n-content="platform"></td>
- <td class="version" id="os_type"><span i18n-content="os_version"></span></td>
+ <td class="version" id="os_type">
+ <span id="os_version" i18n-content="os_version"></span>
+ </td>
</if>
</tr>
<tr><td class="label" valign="top">WebKit</td>
<td class="version" id="webkit_version" i18n-content="webkit_version"></td>
</tr>
<tr><td class="label" valign="top">JavaScript</td>
- <td class="version" id="js_engine"><span i18n-content="js_engine"></span> <span i18n-content="js_version"></span></td>
+ <td class="version" id="js_engine">
+ <span i18n-content="js_engine"></span>
+ <span i18n-content="js_version"></span>
+ </td>
</tr>
<if expr="not pp_ifdef('android')">
<tr><td class="label" valign="top" i18n-content="flash_plugin"></td>
@@ -74,9 +88,7 @@
</tr>
</table>
</div>
- <script src="chrome://resources/js/i18n_template.js"></script>
- <script src="chrome://resources/js/i18n_process.js"></script>
- <script src="chrome://resources/js/jstemplate_compiled.js"></script>
+ <script src="chrome://resources/js/i18n_template2.js"></script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698