Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 10916182: Refactor the about:version code out of about_ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
===================================================================
--- chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (revision 154954)
+++ chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (working copy)
@@ -51,6 +51,7 @@
#include "chrome/browser/ui/webui/task_manager/task_manager_ui.h"
#include "chrome/browser/ui/webui/test_chrome_web_ui_controller_factory.h"
#include "chrome/browser/ui/webui/tracing_ui.h"
+#include "chrome/browser/ui/webui/version_ui.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_switch_utils.h"
@@ -353,14 +354,20 @@
}
#endif
+#if !defined(OS_CHROMEOS)
+ // TODO(stevet): OS_CHROMEOS still uses AboutUI, below. It needs to be
+ // refactored out.
+ if (url.host() == chrome::kChromeUIVersionHost)
+ return &NewWebUI<VersionUI>;
+#endif
+
if (url.host() == chrome::kChromeUIChromeURLsHost ||
url.host() == chrome::kChromeUICreditsHost ||
url.host() == chrome::kChromeUIDNSHost ||
url.host() == chrome::kChromeUIMemoryHost ||
url.host() == chrome::kChromeUIMemoryRedirectHost ||
url.host() == chrome::kChromeUIStatsHost ||
- url.host() == chrome::kChromeUITermsHost ||
- url.host() == chrome::kChromeUIVersionHost
+ url.host() == chrome::kChromeUITermsHost
#if defined(OS_LINUX) || defined(OS_OPENBSD)
|| url.host() == chrome::kChromeUILinuxProxyConfigHost
|| url.host() == chrome::kChromeUISandboxHost
@@ -370,6 +377,7 @@
|| url.host() == chrome::kChromeUINetworkHost
|| url.host() == chrome::kChromeUIOSCreditsHost
|| url.host() == chrome::kChromeUITransparencyHost
+ || url.host() == chrome::kChromeUIVersionHost
#endif
#if defined(WEBUI_TASK_MANAGER)
|| url.host() == chrome::kChromeUITaskManagerHost

Powered by Google App Engine
This is Rietveld 408576698