Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: sync/engine/syncer_proto_util.h

Issue 10916174: Implement a bag of chips for sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/syncer_proto_util.h
diff --git a/sync/engine/syncer_proto_util.h b/sync/engine/syncer_proto_util.h
index b674b50c320c9934ef65587d7d31fed18d9a37b4..d1bfe211619133390143844215d32f519be5f9a8 100644
--- a/sync/engine/syncer_proto_util.h
+++ b/sync/engine/syncer_proto_util.h
@@ -74,6 +74,10 @@ class SyncerProtoUtil {
static const std::string& NameFromCommitEntryResponse(
const sync_pb::CommitResponse_EntryResponse& entry);
+ // Persist an eventual bag of chips sent by the server.
Nicolas Zea 2012/09/07 18:38:43 "Persist a bag of chips"? Not sure what you mean b
qsr 2012/09/10 08:12:37 I mean that if there is not bag of chips, nothing
+ static void PersistBagOfChips(syncable::Directory* dir,
Nicolas Zea 2012/09/07 18:38:43 nit: move first param onto new line so they line u
qsr 2012/09/10 08:12:37 Done, but I followed the style of the next method.
+ const sync_pb::ClientToServerResponse& response);
+
// EntitySpecifics is used as a filter for the GetUpdates message to tell
// the server which datatypes to send back. This adds a datatype so that
// it's included in the filter.
@@ -92,6 +96,11 @@ class SyncerProtoUtil {
static void AddRequestBirthday(syncable::Directory* dir,
sync_pb::ClientToServerMessage* msg);
+ // Pull the bag of chips from the dir and put it into the msg.
+ static void AddBagOfChips(syncable::Directory* dir,
+ sync_pb::ClientToServerMessage* msg);
+
+
// Set the protocol version field in the outgoing message.
static void SetProtocolVersion(sync_pb::ClientToServerMessage* msg);

Powered by Google App Engine
This is Rietveld 408576698