Implement a bag of chips for sync.

sync/engine/process_commit_response_command.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/process_commit_response_command.h"
 
 #include <cstddef>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 44 matching lines @@
       const sessions::OrderedCommitSet& commit_set,
       const sync_pb::ClientToServerMessage& commit_message,
       const sync_pb::ClientToServerResponse& commit_response)
   : commit_set_(commit_set),
     commit_message_(commit_message),
     commit_response_(commit_response) {
 }
 
 ProcessCommitResponseCommand::~ProcessCommitResponseCommand() {}
 
+SyncerError ProcessCommitResponseCommand::ExecuteImpl(SyncSession* session) {

[tim (not reviewing), 2012/09/10 17:52:55]

mm, I understand how you got here, but lets not override this :)

Maybe lets leave ProcessCommitResponseCommand to do the "model changing work",
and move this meta-work to commit.cc, right before invoking
ProcessCommitResponseCommand?

+  syncable::Directory* dir = session->context()->directory();
+  const sync_pb::ClientToServerResponse& response =
+      session->status_controller().updates_response();
+
+  // Persist a bag of chips if it has been sent by the server.
+  SyncerProtoUtil::PersistBagOfChips(dir, response);
+
+  return ModelChangingSyncerCommand::ExecuteImpl(session);
+}
+
 std::set<ModelSafeGroup> ProcessCommitResponseCommand::GetGroupsToChange(
     const sessions::SyncSession& session) const {
   std::set<ModelSafeGroup> groups_with_commits;
 
   syncable::Directory* dir = session.context()->directory();
   syncable::ReadTransaction trans(FROM_HERE, dir);
   for (size_t i = 0; i < commit_set_.Size(); ++i) {
     groups_with_commits.insert(
         GetGroupForModelType(commit_set_.GetModelTypeAt(i),
                              session.routing_info()));
@@ skipping 397 matching lines @@
   // been recursively deleted.
   // TODO(nick): Here, commit_message.deleted() would be more correct than
   // local_entry->Get(IS_DEL).  For example, an item could be renamed, and then
   // deleted during the commit of the rename.  Unit test & fix.
   if (local_entry->Get(IS_DIR) && local_entry->Get(IS_DEL)) {
     deleted_folders->insert(local_entry->Get(ID));
   }
 }
 
 }  // namespace syncer