Implement a bag of chips for sync.

sync/engine/process_commit_response_command_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/process_commit_response_command.h"
 
 #include <vector>
 
 #include "base/location.h"
 #include "base/stringprintf.h"
@@ skipping 360 matching lines @@
         ASSERT_LT(0, c.Get(BASE_VERSION));
       }
     }
     cid = c.Get(syncable::NEXT_ID);
     child_count++;
   }
   ASSERT_EQ(batch_size*2, child_count)
       << "Too few or too many children in parent folder after commit.";
 }
 
+TEST_F(ProcessCommitResponseCommandTest, BagOfChipsPersistence) {
+  sessions::OrderedCommitSet commit_set(session()->routing_info());
+  sync_pb::ClientToServerMessage request;
+  sync_pb::ClientToServerResponse& response =

[Nicolas Zea, 2012/09/07 18:38:43]

nit: make pointer (references should always be const)

[qsr, 2012/09/10 08:12:37]

Done.

+      const_cast<sync_pb::ClientToServerResponse&>(
+          session()->status_controller().updates_response());

[Nicolas Zea, 2012/09/07 18:38:43]

use mutable_updates_response() instead of const_cast

[qsr, 2012/09/10 08:12:37]

 Problem is that status_controller is a const method. Changed the const cast for
status_controller, and then used mutable_updates_response.

+
+  sync_pb::ClientToServerResponse random_message;
+  random_message.set_error_message("hello");
+  random_message.set_store_birthday("world");
+  std::string serialized_message;
+  random_message.SerializeToString(&serialized_message);
+  // Bag Of Chips must be allowed to be extended by the server without the
+  // client noticing. Using a random message for it is a way to check that it is
+  // possible.
+  response.mutable_new_bag_of_chips()->ParseFromString(serialized_message);
+
+  ProcessCommitResponseCommand command(commit_set, request, response);
+  command.ExecuteImpl(session());
+  EXPECT_EQ(serialized_message, directory()->bag_of_chips());
+}
+
 // This test fixture runs across a Cartesian product of per-type fail/success
 // possibilities.
 enum {
   TEST_PARAM_BOOKMARK_ENABLE_BIT,
   TEST_PARAM_AUTOFILL_ENABLE_BIT,
   TEST_PARAM_BIT_COUNT
 };
 class MixedResult :
     public ProcessCommitResponseCommandTest,
     public ::testing::WithParamInterface<int> {
@@ skipping 57 matching lines @@
     EXPECT_EQ("xyz", final_monitor_records["xyz"].extension_id);
     EXPECT_EQ(2049U, final_monitor_records["ABC"].bookmark_write_count);
     EXPECT_EQ(4U,    final_monitor_records["xyz"].bookmark_write_count);
   } else {
     EXPECT_TRUE(final_monitor_records.empty())
         << "Should not restore records after successful bookmark commit.";
   }
 }
 
 }  // namespace syncer