Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: tools/gyp/configurations_xcode.gypi

Issue 10916081: Add secure sockets to dart:io (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Allow TLS sockets to build with both Chromium NSS and upstream NSS Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gyp/configurations_xcode.gypi
diff --git a/tools/gyp/configurations_xcode.gypi b/tools/gyp/configurations_xcode.gypi
index bdd99dfd7af4546b13e240bc8ad374a10dd5a482..9b2bc749a3f2c6ae3d74454026b0bb39ffac74a6 100644
--- a/tools/gyp/configurations_xcode.gypi
+++ b/tools/gyp/configurations_xcode.gypi
@@ -17,9 +17,9 @@
'Dart_Base': {
'xcode_settings': {
# To switch to the LLVM based backend change the two lines below.
- #'GCC_VERSION': 'com.apple.compilers.llvmgcc42',
- 'GCC_VERSION': '4.2',
- 'GCC_C_LANGUAGE_STANDARD': 'ansi',
+ 'GCC_VERSION': 'com.apple.compilers.llvmgcc42',
+ # 'GCC_VERSION': '4.2',
Søren Gjesse 2012/09/28 09:17:31 Why these changes? If compiling NSS require other
Mads Ager (google) 2012/09/28 12:03:57 My guess: Bill probably updated to xcode 4?
Bill Hesse 2012/10/31 16:33:29 Removed. On 2012/09/28 09:17:31, Søren Gjesse wro
+ # 'GCC_C_LANGUAGE_STANDARD': 'ansi',
'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti
'GCC_DEBUGGING_SYMBOLS': 'default', # -g
@@ -27,7 +27,8 @@
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', # -fvisibility-inlines-hidden
'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wnon-virtual-dtor
- 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
+ # 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
+ 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror
'WARNING_CFLAGS': [
'<@(common_gcc_warning_flags)',
'-Wtrigraphs', # Disable Xcode default.

Powered by Google App Engine
This is Rietveld 408576698