Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: runtime/bin/dartutils.cc

Issue 10916081: Add secure sockets to dart:io (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Allow TLS sockets to build with both Chromium NSS and upstream NSS Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/dartutils.cc
diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc
index 35dadfc87b322bc90820b131831061864e9e3fcf..b2d813068ec4ccb1bbc2d95e62385323f542738f 100644
--- a/runtime/bin/dartutils.cc
+++ b/runtime/bin/dartutils.cc
@@ -487,6 +487,13 @@ bool DartUtils::PostInt32(Dart_Port port_id, int32_t value) {
}
+Dart_Handle DartUtils::GetDartClass(const char* library_url,
+ const char* class_name) {
+ return Dart_GetClass(Dart_LookupLibrary(Dart_NewString(library_url)),
Mads Ager (google) 2012/09/28 12:03:56 What is the state of the current Dart API. I forge
Bill Hesse 2012/10/31 16:33:29 The Dart API has been fixed to always return the e
+ Dart_NewString(class_name));
+}
+
+
Dart_Handle DartUtils::NewDartOSError() {
// Extract the current OS error.
OSError os_error;
@@ -496,21 +503,29 @@ Dart_Handle DartUtils::NewDartOSError() {
Dart_Handle DartUtils::NewDartOSError(OSError* os_error) {
// Create a Dart OSError object with the information retrieved from the OS.
- Dart_Handle url = Dart_NewString("dart:io");
- if (Dart_IsError(url)) return url;
- Dart_Handle lib = Dart_LookupLibrary(url);
- if (Dart_IsError(lib)) return lib;
- Dart_Handle class_name = Dart_NewString("OSError");
- if (Dart_IsError(class_name)) return class_name;
- Dart_Handle clazz = Dart_GetClass(lib, class_name);
- if (Dart_IsError(clazz)) return clazz;
+ Dart_Handle clazz = GetDartClass(kIOLibURL, "OSError");
Dart_Handle args[2];
args[0] = Dart_NewString(os_error->message());
- if (Dart_IsError(args[0])) return args[0];
args[1] = Dart_NewInteger(os_error->code());
- if (Dart_IsError(args[1])) return args[1];
- Dart_Handle err = Dart_New(clazz, Dart_Null(), 2, args);
- return err;
+ return Dart_New(clazz, Dart_Null(), 2, args);
+}
+
+
+Dart_Handle DartUtils::NewDartExceptionWithMessage(const char* library_url,
+ const char* exception_name,
+ const char* message) {
+ // Create a Dart Exception object with a message.
+ Dart_Handle clazz = GetDartClass(library_url, exception_name);
+ Dart_Handle args[1];
+ args[0] = Dart_NewString(message);
+ return Dart_New(clazz, Dart_Null(), 1, args);
+}
+
+
+Dart_Handle DartUtils::NewDartIllegalArgumentException(const char* message) {
+ return NewDartExceptionWithMessage(kCoreLibURL,
+ "IllegalArgumentException",
Søren Gjesse 2012/09/28 09:17:31 This is now ArgumentError.
Bill Hesse 2012/10/31 16:33:29 Fixed. On 2012/09/28 09:17:31, Søren Gjesse wrote
+ message);
}

Powered by Google App Engine
This is Rietveld 408576698