Add secure sockets to dart:io

runtime/bin/tls_socket.h

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef BIN_TLS_SOCKET_H_
+#define BIN_TLS_SOCKET_H_
+
+#include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
+#include <sys/types.h>
+
+#include "bin/builtin.h"
+#include "bin/dartutils.h"
+#include "platform/globals.h"
+#include "platform/thread.h"
+
+static Dart_Handle HandleError(Dart_Handle handle) {

[Mads Ager (google), 2012/09/28 12:03:57]

As you know, I'm on the fence on this one. If we want it we should put it in
dart_utils and use it consistently throughout. It might be a good idea to do so.
Currently, we have asserts all over that !Dart_IsError(something) where the
right thing would be to propagate the error.

Could you move this to dart_utils.h and file a bug report that propagation of
errors are missing for most of the dart:io C++ code.

Maybe we can call this something that more closely matches the API function it
is using: PropagateError / PropagateErrorIfNeeded / PropagateIfError? Not sure.

[Bill Hesse, 2012/10/31 16:33:29]

Done.

On 2012/09/28 12:03:57, Mads Ager wrote:

+  if (Dart_IsError(handle)) Dart_PropagateError(handle);
+  return handle;
+}
+
+
+class TlsFilterPlatformData;
+
+class TlsFilter {
+ public:
+  enum BufferIndex { kReadPlaintext,
+                     kWritePlaintext,
+                     kReadEncrypted,
+                     kWriteEncrypted,
+                     kNumBuffers};
+
+  TlsFilter();
+  void Init(Dart_Handle dart_this);
+  void Connect();
+  void Destroy();
+  void DestroyPlatformIndependent();
+  void RegisterHandshakeCallbacks(Dart_Handle start, Dart_Handle finish);
+  static void InitializeLibrary(const char* pkcert_directory);
+
+  intptr_t ProcessBuffer(int bufferIndex);
+
+ private:
+  //  static const char* bufferNames_[kNumBuffers];
+  static bool library_initialized_;  // Should be mutex protected.
+
+  uint8_t* buffers_[kNumBuffers];
+  int64_t buffer_size_;
+  Dart_Handle stringStart_;
+  Dart_Handle stringLength_;
+  Dart_Handle dart_buffer_objects_[kNumBuffers];
+  Dart_Handle handshake_start_;
+  Dart_Handle handshake_finish_;
+  bool in_handshake_;
+  TlsFilterPlatformData* data_;
+
+  void InitializeBuffers(Dart_Handle dart_this);
+  void InitializePlatformData();
+  static void LockInitMutex() {}
+  static void UnlockInitMutex() {}
+
+  DISALLOW_COPY_AND_ASSIGN(TlsFilter);
+};
+
+#endif  // BIN_TLS_SOCKET_H_