Add secure sockets to dart:io

runtime/bin/dartutils.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 
 #include "bin/extensions.h"
 #include "bin/directory.h"
 #include "bin/file.h"
 #include "include/dart_api.h"
@@ skipping 469 matching lines @@
   int32_t min = 0xc0000000;  // -1073741824
   int32_t max = 0x3fffffff;  // 1073741823
   ASSERT(min <= value && value < max);
   Dart_CObject object;
   object.type = Dart_CObject::kInt32;
   object.value.as_int32 = value;
   return Dart_PostCObject(port_id, &object);
 }
 
 
+Dart_Handle DartUtils::GetDartClass(const char* library_url,
+                                    const char* class_name) {
+  return Dart_GetClass(Dart_LookupLibrary(Dart_NewString(library_url)),

[Mads Ager (google), 2012/09/28 12:03:56]

What is the state of the current Dart API. I forget - does it always return an
error handle when one of the arguments is an error handle? If now, we might have
to split this out:

Dart_Handle lib = Dart_LookupLibrary(Dart_NewString(library_url));
if (Dart_IsError(lib)) return lib;
return Dart_GetClass(lib, Dart_NewString(class_name));

[Bill Hesse, 2012/10/31 16:33:29]

The Dart API has been fixed to always return the error handle that is passed in
as an argument, if the return value is a handle, exactly so this sort of code
can be written.

On 2012/09/28 12:03:56, Mads Ager wrote:

+                       Dart_NewString(class_name));
+}
+
+
 Dart_Handle DartUtils::NewDartOSError() {
   // Extract the current OS error.
   OSError os_error;
   return NewDartOSError(&os_error);
 }
 
 
 Dart_Handle DartUtils::NewDartOSError(OSError* os_error) {
   // Create a Dart OSError object with the information retrieved from the OS.
-  Dart_Handle url = Dart_NewString("dart:io");
-  if (Dart_IsError(url)) return url;
-  Dart_Handle lib = Dart_LookupLibrary(url);
-  if (Dart_IsError(lib)) return lib;
-  Dart_Handle class_name = Dart_NewString("OSError");
-  if (Dart_IsError(class_name)) return class_name;
-  Dart_Handle clazz = Dart_GetClass(lib, class_name);
-  if (Dart_IsError(clazz)) return clazz;
+  Dart_Handle clazz = GetDartClass(kIOLibURL, "OSError");
   Dart_Handle args[2];
   args[0] = Dart_NewString(os_error->message());
-  if (Dart_IsError(args[0])) return args[0];
   args[1] = Dart_NewInteger(os_error->code());
-  if (Dart_IsError(args[1])) return args[1];
-  Dart_Handle err = Dart_New(clazz, Dart_Null(), 2, args);
-  return err;
+  return Dart_New(clazz, Dart_Null(), 2, args);
 }
 
 
+Dart_Handle DartUtils::NewDartExceptionWithMessage(const char* library_url,
+                                                   const char* exception_name,
+                                                   const char* message) {
+  // Create a Dart Exception object with a message.
+  Dart_Handle clazz = GetDartClass(library_url, exception_name);
+  Dart_Handle args[1];
+  args[0] = Dart_NewString(message);
+  return Dart_New(clazz, Dart_Null(), 1, args);
+}
+
+
+Dart_Handle DartUtils::NewDartIllegalArgumentException(const char* message) {
+  return NewDartExceptionWithMessage(kCoreLibURL,
+                                     "IllegalArgumentException",

[Søren Gjesse, 2012/09/28 09:17:31]

This is now ArgumentError.

[Bill Hesse, 2012/10/31 16:33:29]

Fixed.

On 2012/09/28 09:17:31, Søren Gjesse wrote:

+                                     message);
+}
+
+
 void DartUtils::SetOriginalWorkingDirectory() {
   original_working_directory = Directory::Current();
 }
 
 
 // Statically allocated Dart_CObject instances for immutable
 // objects. As these will be used by different threads the use of
 // these depends on the fact that the marking internally in the
 // Dart_CObject structure is not marking simple value objects.
 Dart_CObject CObject::api_null_ = { Dart_CObject::kNull , { 0 } };
@@ skipping 133 matching lines @@
 
 CObject* CObject::NewOSError(OSError* os_error) {
   CObject* error_message =
       new CObjectString(CObject::NewString(os_error->message()));
   CObjectArray* result = new CObjectArray(CObject::NewArray(3));
   result->SetAt(0, new CObjectInt32(CObject::NewInt32(kOSError)));
   result->SetAt(1, new CObjectInt32(CObject::NewInt32(os_error->code())));
   result->SetAt(2, error_message);
   return result;
 }