Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: net/udp/udp_socket_unittest.cc

Issue 10916052: Fixed UDP tests for MacOS X 10.7 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/udp/udp_socket_unittest.cc
diff --git a/net/udp/udp_socket_unittest.cc b/net/udp/udp_socket_unittest.cc
index 2da866df97189af9455ebcfb8734b422c7bef0c7..4edbad7da2bd1d9eae2694944f10371a89067172 100644
--- a/net/udp/udp_socket_unittest.cc
+++ b/net/udp/udp_socket_unittest.cc
@@ -2,6 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#if defined(OS_MACOSX)
+#include <unistd.h>
Sergey Ulanov 2012/09/05 22:23:56 You need to move this after udp_server_socket.h an
ygorshenin1 2012/09/06 08:01:26 Done.
+#endif // defined(OS_MACOSX)
+
#include "net/udp/udp_client_socket.h"
#include "net/udp/udp_server_socket.h"
@@ -131,10 +135,11 @@ TEST_F(UDPSocketTest, Connect) {
// Setup the server to listen.
IPEndPoint bind_address;
- CreateUDPAddress("0.0.0.0", kPort, &bind_address);
+ CreateUDPAddress("127.0.0.1", kPort, &bind_address);
CapturingNetLog server_log;
scoped_ptr<UDPServerSocket> server(
new UDPServerSocket(&server_log, NetLog::Source()));
+ server->AllowAddressReuse();
int rv = server->Listen(bind_address);
EXPECT_EQ(OK, rv);
@@ -202,6 +207,13 @@ TEST_F(UDPSocketTest, Connect) {
}
TEST_F(UDPSocketTest, Broadcast) {
+#if defined(OS_MACOSX)
+ if (getuid() != 0) {
+ LOG(ERROR) <<
+ "Skipping Broadcast test because it requires root permissions on OSX";
+ return;
+ }
+#endif // defined(OS_MACOSX)
const int kPort = 9999;
std::string first_message("first message"), second_message("second message");
@@ -335,14 +347,16 @@ TEST_F(UDPSocketTest, VerifyConnectBindsAddr) {
// Setup the first server to listen.
IPEndPoint bind_address;
- CreateUDPAddress("0.0.0.0", kPort1, &bind_address);
+ CreateUDPAddress("127.0.0.1", kPort1, &bind_address);
UDPServerSocket server1(NULL, NetLog::Source());
+ server1.AllowAddressReuse();
int rv = server1.Listen(bind_address);
EXPECT_EQ(OK, rv);
// Setup the second server to listen.
- CreateUDPAddress("0.0.0.0", kPort2, &bind_address);
+ CreateUDPAddress("127.0.0.1", kPort2, &bind_address);
UDPServerSocket server2(NULL, NetLog::Source());
+ server2.AllowAddressReuse();
rv = server2.Listen(bind_address);
EXPECT_EQ(OK, rv);
« chrome/test/ppapi/ppapi_browsertest.cc ('K') | « chrome/test/ppapi/ppapi_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698