Fixed UDP tests for MacOS X 10.7

chrome/test/ppapi/ppapi_browsertest.cc

Index: chrome/test/ppapi/ppapi_browsertest.cc
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc
index e7e7f9c9eb63d688dee342e6a713261297967c69..09f739fb34f612aab5c7606bb730c1da2a738e20 100644
--- a/chrome/test/ppapi/ppapi_browsertest.cc
+++ b/chrome/test/ppapi/ppapi_browsertest.cc
@@ -287,9 +287,27 @@ TEST_PPAPI_NACL_WITH_SSL_SERVER(MAYBE_TCPSocketPrivate)
 TEST_PPAPI_OUT_OF_PROCESS_WITH_SSL_SERVER(TCPSocketPrivateTrusted)
 TEST_PPAPI_IN_PROCESS_WITH_SSL_SERVER(TCPSocketPrivateTrusted)
 
-TEST_PPAPI_IN_PROCESS_VIA_HTTP(UDPSocketPrivate)
-TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate)
-TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivate)
+// UDPSocketPrivate tests.
+// UDPSocketPrivate_Broadcast is disabled for OSX because it requires

[viettrungluu, 2012/09/10 17:51:10]

Maybe it's better to just remove the broadcast test from
TestUDPSocketPrivate::RunTests() on Mac and NaCl? (This would of course mean
never testing broadcast in NaCl -- do we really need broadcast in NaCl?
Especially since it's apparently no longer a platform-independent capability?)

(What you've done here is not only rather messy, but there's also high
probability that anyone adding new UDP tests will forget to add them here;
keeping the list of tests in sync is a pain.)

[ygorshenin1, 2012/09/10 18:05:22]

From NaCl broadcasting is not a capability --- it's a special "feature" which is
handled individually for Mac, Win and Linux. Take a look at
http://code.google.com/searchframe#OAMlx_jo-ck/src/net/udp/udp_socket_libeven...
and
http://code.google.com/searchframe#OAMlx_jo-ck/src/net/udp/udp_socket_win.cc&....

On 2012/09/10 17:51:10, viettrungluu wrote:

+// root permissions on OSX 10.7+.
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(UDPSocketPrivate_Connect)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(UDPSocketPrivate_ConnectFailure)
+#if !defined(OS_MACOSX)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(UDPSocketPrivate_Broadcast)
+#endif  // !defined(OS_MACOSX)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(UDPSocketPrivate_SetSocketFeatureErrors)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_Connect)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_ConnectFailure)
+#if !defined(OS_MACOSX)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_Broadcast)
+#endif  // !defined(OS_MACOSX)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_SetSocketFeatureErrors)
+TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivate_Connect)
+TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivate_ConnectFailure)
+#if !defined(OS_MACOSX)
+TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivate_Broadcast)
+#endif  // !defined(OS_MACOSX)
+TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivate_SetSocketFeatureErrors)
 
 TEST_PPAPI_NACL_VIA_HTTP_DISALLOWED_SOCKETS(TCPServerSocketPrivateDisallowed)
 TEST_PPAPI_NACL_VIA_HTTP_DISALLOWED_SOCKETS(TCPSocketPrivateDisallowed)