Fixed UDP tests for MacOS X 10.7

net/udp/udp_socket_unittest.cc

Index: net/udp/udp_socket_unittest.cc
diff --git a/net/udp/udp_socket_unittest.cc b/net/udp/udp_socket_unittest.cc
index 2da866df97189af9455ebcfb8734b422c7bef0c7..9988441c27c524fe78ac7e07f8927939faedd7dd 100644
--- a/net/udp/udp_socket_unittest.cc
+++ b/net/udp/udp_socket_unittest.cc
@@ -131,10 +131,11 @@ TEST_F(UDPSocketTest, Connect) {
 
   // Setup the server to listen.
   IPEndPoint bind_address;
-  CreateUDPAddress("0.0.0.0", kPort, &bind_address);
+  CreateUDPAddress("127.0.0.1", kPort, &bind_address);
   CapturingNetLog server_log;
   scoped_ptr<UDPServerSocket> server(
       new UDPServerSocket(&server_log, NetLog::Source()));
+  server->AllowAddressReuse();
   int rv = server->Listen(bind_address);
   EXPECT_EQ(OK, rv);
 
@@ -201,6 +202,9 @@ TEST_F(UDPSocketTest, Connect) {
       client_entries, 5, NetLog::TYPE_SOCKET_ALIVE));
 }
 
+#if !defined(OS_MACOSX)
+
+// TODO (ygorshenin): crbug.com/145487

[Sergey Ulanov, 2012/09/04 21:27:32]

It's better to keep the test but just skip this test when not running as root,
e.g.
#if !defined(OS_MACOSX)
  if (getuid() != 0) {
    LOG(ERROR) << "Skipping Broadcast test because it requires root permissions
on OSX";
    return;
  }
#endif  // !defined (OS_MAXOSX)

[ygorshenin1, 2012/09/05 13:25:45]

Done.

 TEST_F(UDPSocketTest, Broadcast) {
   const int kPort = 9999;
   std::string first_message("first message"), second_message("second message");
@@ -240,6 +244,8 @@ TEST_F(UDPSocketTest, Broadcast) {
   ASSERT_EQ(second_message, str);
 }
 
+#endif

[Sergey Ulanov, 2012/09/04 21:27:32]

add  // !defined (OS_MAXOSX)

[ygorshenin1, 2012/09/05 13:25:45]

Done.

+
 // In this test, we verify that random binding logic works, which attempts
 // to bind to a random port and returns if succeeds, otherwise retries for
 // |kBindRetries| number of times.
@@ -335,14 +341,16 @@ TEST_F(UDPSocketTest, VerifyConnectBindsAddr) {
 
   // Setup the first server to listen.
   IPEndPoint bind_address;
-  CreateUDPAddress("0.0.0.0", kPort1, &bind_address);
+  CreateUDPAddress("127.0.0.1", kPort1, &bind_address);
   UDPServerSocket server1(NULL, NetLog::Source());
+  server1.AllowAddressReuse();
   int rv = server1.Listen(bind_address);
   EXPECT_EQ(OK, rv);
 
   // Setup the second server to listen.
-  CreateUDPAddress("0.0.0.0", kPort2, &bind_address);
+  CreateUDPAddress("127.0.0.1", kPort2, &bind_address);
   UDPServerSocket server2(NULL, NetLog::Source());
+  server2.AllowAddressReuse();
   rv = server2.Listen(bind_address);
   EXPECT_EQ(OK, rv);