Throw AbstractClassInstantiationError if an abstract class is instantiated

runtime/lib/error.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/error.h"
 
 #include "vm/bootstrap_natives.h"
 #include "vm/exceptions.h"
 #include "vm/object_store.h"
 #include "vm/runtime_entry.h"
@@ skipping 85 matching lines @@
   intptr_t line, column;
   script.GetTokenLocation(fallthrough_pos, &line, &column);
   Exceptions::SetField(fallthrough_error, cls, "line",
                        Smi::Handle(Smi::New(line)));
 
   // Throw FallThroughError instance.
   Exceptions::Throw(fallthrough_error);
   UNREACHABLE();
   return Object::null();
 }
 

[regis, 2012/08/31 01:16:48]

Missing blank line.
Also, missing comment documenting arguments, as all other runtime entries do. 

[hausner, 2012/08/31 18:06:52]

Done.

+DEFINE_NATIVE_ENTRY(AbstractClassInstantiationError_throwNew, 2) {
+  GET_NATIVE_ARGUMENT(Smi, smi_pos, arguments->At(0));
+  GET_NATIVE_ARGUMENT(String, class_name, arguments->At(1));
+  intptr_t error_pos = smi_pos.Value();
+
+  // Allocate a new instance of type AbstractClassInstantiationError.
+  const Instance& error = Instance::Handle(Exceptions::NewInstance(
+      "AbstractClassInstantiationErrorImplementation"));
+  ASSERT(!error.IsNull());
+
+  // Initialize 'url', 'line' and 'className' fields.
+  DartFrameIterator iterator;
+  iterator.NextFrame();  // Skip native call.
+  const Script& script = Script::Handle(Exceptions::GetCallerScript(&iterator));
+  const Class& cls = Class::Handle(error.clazz());
+  Exceptions::SetField(error, cls, "url", String::Handle(script.url()));
+  intptr_t line, column;
+  script.GetTokenLocation(error_pos, &line, &column);
+  Exceptions::SetField(error, cls, "line", Smi::Handle(Smi::New(line)));
+  Exceptions::SetField(error, cls, "className", class_name);
+
+  // Throw AbstractClassInstantiationError instance.
+  Exceptions::Throw(error);
+  UNREACHABLE();
+  return Object::null();
+}
 

[regis, 2012/08/31 01:16:48]

Missing blank line.

[hausner, 2012/08/31 18:06:52]

Done.

 // Allocate and throw StaticResolutionException.
 // Arg0: index of the static call that was not resolved at compile time.
 // Return value: none, throws an exception.
 DEFINE_NATIVE_ENTRY(StaticResolutionException_throwNew, 1) {
   GET_NATIVE_ARGUMENT(Smi, smi_pos, arguments->At(0));
   intptr_t call_pos = smi_pos.Value();
   // Allocate a new instance of type StaticResolutionException.
   const Instance& resolution_exception =
       Instance::Handle(Exceptions::NewInstance("StaticResolutionException"));
   ASSERT(!resolution_exception.IsNull());
 
   // Initialize 'url', 'line', and 'column' fields.
   DartFrameIterator iterator;
   iterator.NextFrame();  // Skip native call.
   const Script& script = Script::Handle(Exceptions::GetCallerScript(&iterator));
   const Class& cls = Class::Handle(resolution_exception.clazz());
   Exceptions::SetLocationFields(resolution_exception, cls, script, call_pos);
 
   intptr_t line, column;
   script.GetTokenLocation(call_pos, &line, &column);
   Exceptions::SetField(resolution_exception, cls, "failedResolutionLine",
                        String::Handle(script.GetLine(line)));
 
   Exceptions::Throw(resolution_exception);
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart