Make DownloadHistory observe manager, items

chrome/browser/ui/webui/downloads_dom_handler.cc

Index: chrome/browser/ui/webui/downloads_dom_handler.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc
index be92a11a353bae762cca5328e4300147b70a4951..2e1d64c3ced05c765d7ee03c41cb3d827668c51e 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc
@@ -416,7 +416,6 @@ void DownloadsDOMHandler::HandleRemove(const base::ListValue* args) {
   CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_REMOVE);
   content::DownloadItem* file = GetDownloadByValue(args);
   if (file) {
-    DCHECK(file->IsPersisted());

[Randy Smith (Not in Mondays), 2012/09/11 18:36:53]

Any idea why this check was here in the first place?

[benjhayden, 2012/09/13 15:18:16]

When a user clicks "Remove" on chrome://downloads, they expect it to disappear.
If this item wasn't persisted, then Remove()ing it might not disappear it. We'd
want to catch that.
Now, though, DownloadManager removes it from its downloads_ map regardless of
what DownloadDatabase says, so it will disappear.

     file->Remove();
   }
 }